5.1 KiB
5.1 KiB
Review Board E2E Flows
These flows cover the reviewer-agent UI as an orchestrator-owned surface, not as a second
command center. The project orchestrator is the entry point for creating and running reviews.
The review board observes, inspects, and navigates reviewer work. Reviewer runs remain linked to
a coding worker, but they must not reuse the worker's terminal context.
Flow 1: Enter through the project orchestrator
- Open the project coding dashboard at
/projects/:projectId. - Open the header
Orchestratoraction. - Confirm the app lands on
/projects/:projectId/sessions/:orchestratorId. - Confirm this is the project orchestrator session, not a worker or reviewer session.
Flow 2: Coding to Reviews navigation stays available
- Open the project coding dashboard at
/projects/:projectId. - Confirm the shared header shows
Codingas the active workspace mode. - Click
Reviews. - Confirm the browser lands on
/review?project=:projectId. - Confirm
Reviewsis now active andCodinglinks back to/projects/:projectId.
Flow 3: Orchestrator requests reviews
- Start with a worker card that is ready for review.
- From the orchestrator flow, issue the AO review command for that worker.
- Confirm a queued review run appears on the review board.
- Confirm the review run is linked to the coding worker and displays worker metadata.
- Confirm no reviewer coding session metadata is created.
Flow 4: Orchestrator executes multiple queued reviewer runs
- Create at least two queued review runs.
- From the orchestrator flow, issue two reviewer execution commands without waiting between them.
- Confirm both cards can be observed in a reviewing state.
- Confirm completed runs move to either
Triagewhen findings exist orCleanwhen no findings exist.
Flow 5: Inspect findings
- Let the orchestrator execute a run whose reviewer result contains a finding.
- Confirm the run lands in
Triage. - Click the
viewfinding action or the carddetailsaction. - Confirm the details panel lists severity, title, location, body, open count, total count, and worker actions.
- Close the drawer with the close button or Escape.
Flow 6: Worker and orchestrator links
- From a review card, click
Worker. - Confirm the app navigates to the coding dashboard focused on the linked worker.
- Return to the review board.
- Confirm the header
Orchestratoraction opens or restores the same project orchestrator used by the coding dashboard.
Flow 7: Failure and retry
- Execute a queued run with a reviewer command that fails.
- Confirm the card moves to
Failed. - From the orchestrator flow, issue a retry command for the same run.
- Confirm the retry can execute the same run again with
force: true.
Flow 8: Feedback availability
- Show a review run linked to a worker with no live runtime.
- Confirm the card shows the worker runtime state instead of a
Feedbackaction. - Show a review run linked to a live worker.
- Confirm
Feedbacksends open review findings to the linked worker. - Confirm the app opens the worker terminal section after the send succeeds.
Flow 9: CLI and UI share the same review store
- Request a review through the orchestrator AO command path.
- Confirm the run appears in
/review?project=:projectIdwithout refreshing any mocked data. - Execute that run through the orchestrator AO command path and a deterministic local reviewer command.
- Confirm the UI reflects the persisted result after a reload.
Flow 10: Clean review result
- Let the orchestrator execute a reviewer command that returns
{"findings":[]}. - Confirm the run moves to
Clean. - Confirm the card reports
0 findings. - Open details and confirm it reports no captured findings.
Flow 11: Reviewer isolation from coding sessions
- Execute a reviewer run.
- Confirm the reviewer has a snapshot workspace under
code-reviews/workspaces/:reviewerSessionId. - Confirm there is no coding session metadata file for
:reviewerSessionId. - Confirm the linked worker card and terminal route remain the coding worker, not the reviewer.
Flow 12: New worker commit supersedes old review runs
- Complete a review for the worker's current
HEAD. - Commit a new change in the worker repository.
- From the orchestrator flow, request a new review for the same worker.
- Confirm older review runs for the previous
HEADmove toOutdated. - Confirm the new review remains actionable in
Queued.
Flow 13: Same orchestrator across modes
- Open the coding dashboard and capture the header
Orchestratorlink. - Open the review board and capture the header
Orchestratorlink. - Confirm both links point to the same project orchestrator session.
- Confirm the review board does not offer
Spawn Orchestratorwhen one already exists.
Flow 14: Send reviewer findings back to worker
- Complete a review run with open findings.
- From the review board, click
Feedbackfor that review run. - Confirm AO sends the stored finding details to the linked coding worker.
- Confirm the review run moves to
Waiting. - Confirm open findings become sent findings and are no longer counted as open.