- Remove phantom `projects` prop from test setup (was dead code)
- Deduplicate test coverage: consolidate component tests into
OrchestratorSelector.test.tsx, keep only page route tests in
orchestrators.test.tsx
- Fix useRouter mock to capture and assert router.push calls
- Add finally block to handleSpawnNew for resilience (ensures
isSpawning is reset even if router.push fails)
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Fix tmux target to use session ID when runtimeHandle is missing,
preventing references to non-existent sessions
- Extract mapSessionsToOrchestrators helper to eliminate duplicate
orchestrator listing logic between page.tsx and API route
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Export Orchestrator interface from OrchestratorSelector component
and import it in page.tsx to avoid silent divergence risk.
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Update existing test to verify the new --no-dashboard auto-select
behavior and add a separate test for dashboard-enabled selection
message.
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
When --no-dashboard is used and existing orchestrators are found,
auto-select the most recently active one instead of deferring to
dashboard selection (which isn't available). This ensures the CLI
remains usable without the dashboard.
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
The sm.list() call was outside the existing try/catch that handles
orchestrator setup failures. If listing sessions throws, the spinner
could be left running and the dashboard process could leak.
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
The projects prop was declared and passed but never used, causing
unnecessary data fetching and serialization. Removed the prop from
the component interface, page, and tests.
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Guard against NaN timestamps from invalid ISO date strings and handle
future timestamps gracefully by returning "Just now" instead of
negative values.
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
When ao start is run and existing orchestrator sessions exist for the
project, the CLI now skips spawning a new one. Instead:
- Detects existing orchestrator sessions before spawning
- Opens the dashboard to a new /orchestrators page for session selection
- Users can resume an existing orchestrator or start a new one
Changes:
- packages/cli/src/commands/start.ts: Check for existing orchestrators,
redirect to selection page if found
- packages/web/src/app/api/orchestrators/route.ts: Add GET endpoint to
list orchestrators for a project
- packages/web/src/app/orchestrators/page.tsx: New page for orchestrator
selection
- packages/web/src/components/OrchestratorSelector.tsx: UI component for
selecting or spawning orchestrators
- packages/web/src/components/__tests__/OrchestratorSelector.test.tsx:
Tests for the selector component
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
* feat: support multiple concurrent orchestrators with isolated worktrees
- Each orchestrator session gets a numbered ID ({prefix}-orchestrator-N)
and an isolated git worktree, replacing the single shared orchestrator
- reserveNextOrchestratorIdentity atomically reserves the next available
number and detects conflicting project prefix configurations early
- isOrchestratorSession / isOrchestratorSessionName accept optional
allSessionPrefixes for cross-project false-positive prevention
- getProjectPause and resolveGlobalPause track the longest active pause
across all concurrent orchestrators instead of returning the first found
- cleanupWorktreeAndMetadata helper used consistently on all failure paths
including post-launch; system prompt file included in cleanup
- pollBacklog, status.ts, ProjectSidebar, sessions page, global-pause,
project-utils, serialize, and sessions API route all pass
allSessionPrefixes to isOrchestratorSession
- Web sessions/[id]/page.tsx fetches project prefix map and passes it
through prefixByProjectRef to avoid stale closure in fetchProjectSessions
* fix: seed sseAttentionLevels from fresh sessions on full refresh
When scheduleRefresh dispatches a reset action, derive sseAttentionLevels
from the freshly fetched sessions using getAttentionLevel. This clears
phantom entries for removed sessions and seeds correct levels for new
sessions, preventing stale favicon color and attention counts until the
next SSE snapshot.
* fix: merge duplicate @/lib/types imports into single import statement
Combining the separate import type and value import from @/lib/types
into one import to satisfy the no-duplicate-imports lint rule.
- Fix bad temp name for non-standard packages: use full packageName
instead of last hyphen-segment to avoid collisions between packages
like "custom-tracker-plugin" and "my-custom-plugin"
- Fix disabled top-level plugin blocking inline loading: when an
existing plugin entry has `enabled: false`, it's now set to `true`
when there's an inline tracker/scm/notifier reference for the same
package/path
- Create validatePluginConfigFields helper to deduplicate the
TrackerConfigSchema, SCMConfigSchema, and NotifierConfigSchema
validation logic (was duplicated thrice)
- Fix multi-project external plugin order-dependency: tracker and SCM
plugins now receive no project-level config at create() time, making
them consistent with built-in plugins. Project-specific config is
passed per-call via ProjectConfig argument, avoiding first-project
wins behavior
- Document post-validation invariant for plugin field: added
documentation clarifying that `plugin` is always populated after
validateConfig() to help downstream consumers understand they can
safely assume non-null after validation
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
* fix(agent-claude-code): return idle state when no JSONL session file exists
Freshly spawned sessions had no Claude Code JSONL file yet (Claude Code
doesn't create it until the first conversation), causing getActivityState
to return null → displayed as 'unknown' in ao status.
When the process is running but no session file exists, return
{ state: 'idle', timestamp: now } so the dashboard shows the correct
state immediately after spawn.
Closes#883
* fix(agent-claude-code): use session.createdAt for idle timestamp when no JSONL file
Using new Date() as the timestamp caused isIdleBeyondThreshold to always
compute ~0ms, preventing stuck detection from ever firing for sessions that
hang before creating a JSONL file. Using session.createdAt correctly
represents when the session began, allowing stuck detection to eventually
trigger.
* feat: event-driven live tab titles and favicons via SSE
Switch tab titles and favicons from polling to real-time SSE updates:
- Extend useSessionEvents to expose sseAttentionLevels map from SSE
snapshots (server-computed, includes full PR state)
- Refactor DynamicFavicon to use SSE attention levels instead of
recomputing from the full sessions array (which has stale PR data
between refreshes)
- Add useSSESessionActivity hook for session detail page to update
document.title emoji immediately on activity change
- Add live dashboard title showing count of sessions needing attention
- Update PullRequestsPage to use new DynamicFavicon API
Closes#115
* fix: seed initial attention levels to avoid stale favicon/title on first render
Accept initialAttentionLevels parameter in useSessionEvents so callers
can seed the attention map from initialSessions via getAttentionLevel().
This prevents the favicon and dashboard title from briefly showing
"all clear" before the first SSE snapshot arrives.
* fix: add EventSource mock to session page test for SSE hook compatibility
* fix: reset stale activity state when sessionId changes in useSSESessionActivity
Add sessionId to the effect dependency array and reset state to null at
the start of each effect run so callers that reuse the hook with a
different sessionId don't see the previous session's activity.
* fix: reset sseAttentionLevels on initialSessions change to prevent stale data on project switch
The reset action now accepts an optional sseAttentionLevels field. When
initialSessions changes (e.g., project switch via sidebar), the dispatch
passes the current initialAttentionLevels via ref so the favicon and
dashboard title reflect the new project immediately rather than showing
stale attention data until the first SSE snapshot.
extractPluginConfig was being called with mod.manifest.name before the
config was updated from the temp name. When manifest name differs from
temp name (e.g., temp "teams" vs manifest "ms-teams"), extractPluginConfig
found no match and returned undefined, causing the plugin to be registered
without its configuration (webhook URLs, tokens, etc.).
Fix by reordering operations:
1. Validate and update configs with manifest.name FIRST
2. Extract plugin config AFTER (now finds the config by manifest.name)
3. Register plugin with its correct configuration
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
When multiple projects share the same external plugin, a misconfiguration
in one project (wrong expectedPluginName) would prevent the plugin from
being registered at all, silently breaking it for all projects.
Fix by:
1. Register the plugin FIRST, before validating individual project configs
2. Validate each project's config in its own try-catch
3. Log validation errors but continue processing other projects
This ensures:
- Plugin is always registered if it loads successfully
- Projects with correct config get updated
- Projects with bad config get a warning but don't break others
- Misconfigured projects fail at point of use with clearer errors
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
generateTempPluginName was splitting package names on both hyphens and
slashes, which truncated multi-word names like "jira-cloud" to just
"cloud".
Fix by first extracting the package name without scope, then using a
regex to match the common ao-plugin-{slot}-{name} pattern which
preserves the full plugin name including hyphens.
Examples:
- @acme/ao-plugin-tracker-jira-cloud -> jira-cloud (was: cloud)
- ao-plugin-scm-azure-devops -> azure-devops (was: devops)
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Strip package and path loading metadata from notifier config passed
to plugin create(). These fields are used for plugin resolution, not
plugin-specific configuration. Prevents filesystem paths from leaking
into plugin config where they could conflict with plugin-specific
fields of the same name.
- Remove collectExternalPluginConfigs from public API exports since it
is only used internally within config.ts during validateConfig.
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Fix multiple projects sharing same external plugin: change
findExternalPluginEntry to findAllExternalPluginEntries which returns
all matching entries, allowing all projects to be updated with the
actual manifest.name
- Fix path without slashes misidentified as npm package: use separate
pkg and path parameters in generateTempPluginName instead of combining
them and checking for slashes. Local paths like "my-tracker" (no
slashes) are now correctly returned as-is
- Replace console.warn with process.stderr.write for structured logging
in plugin-registry.ts
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Remove unused collectExternalPluginConfigs import from tests
- Add missing location field to _externalPluginEntries in test
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
1. Only set expectedPluginName when user explicitly specifies `plugin`
- Auto-generated temp names no longer block manifest name inference
- External plugins like @acme/ao-plugin-tracker-jira-cloud with
manifest.name "jira-cloud" will now load correctly
2. Add structured location data to ExternalPluginEntryRef
- New ExternalPluginLocation type with kind/projectId/configType
- Avoids fragile string parsing of source (project/notifier keys
can legally contain dots)
3. Expand home paths (~/) in inline plugin configs
- Apply expandHome() to tracker/scm/notifier path fields
- Consistent behavior with config.plugins path expansion
4. Improve error messages
- Use "package" vs "path" in manifest mismatch errors instead
of always saying "package"
5. Fix tests to use config._externalPluginEntries
- Tests now check entries stored by validateConfig() instead
of calling collectExternalPluginConfigs() again on modified config
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Update all usages of project.tracker.plugin and project.scm.plugin
to use optional chaining since the plugin field is now optional
when package or path fields are specified.
Files updated:
- CLI: doctor.ts, status.ts, verify.ts
- Web: issues/route.ts, verify/route.ts, scm-webhooks.ts,
serialize.ts, services.ts
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Add support for specifying external plugins inline in tracker, scm, and
notifier configs using optional `package` or `path` fields.
**Config schema changes:**
- TrackerConfig, SCMConfig, NotifierConfig now accept optional `package`
(npm) or `path` (local) fields alongside the existing `plugin` field
- When only `package`/`path` is specified, plugin name is auto-inferred
- When both `plugin` and `package`/`path` are specified, manifest.name
is validated against the declared plugin name
**Example usage:**
```yaml
projects:
my-app:
tracker:
plugin: jira # optional - validates against manifest.name
package: "@acme/ao-plugin-tracker-jira"
teamId: "TEAM-123"
scm:
path: ./plugins/my-scm # local plugin
notifiers:
teams:
package: "@acme/ao-plugin-notifier-teams"
```
**Implementation details:**
- collectExternalPluginConfigs() extracts external plugin entries from
tracker/scm/notifier configs during config validation
- Auto-generates InstalledPluginConfig entries merged into config.plugins
- Plugin registry validates manifest.name matches expectedPluginName and
updates config with actual manifest.name after loading
- Warns when plugin slot doesn't match configured slot
Closes#736
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
* feat: add CI failure detail notifications in lifecycle manager
When CI fails on a PR, the lifecycle manager now fetches individual check
details (names, statuses, URLs) and sends them to the worker session.
This complements the existing static reaction message with actionable
debugging information.
Flow:
- On first transition to ci_failed: static reaction message fires (existing)
- On next poll: detailed CI failure info with check names and URLs dispatched
- Fingerprinting prevents re-sending the same failure set
- New/changed failures trigger fresh detailed notifications
- Tracking metadata cleared when PR is merged/closed or CI passes
Follows the same deduplication pattern as maybeDispatchReviewBacklog().
* fix: send CI details directly to avoid consuming reaction retry budget
The detailed CI failure dispatch now uses sessionManager.send() directly
instead of executeReaction(), so it doesn't increment the ci-failed
reaction tracker. This prevents low retries/escalateAfter settings from
causing premature escalation before the agent receives failure details.
The transition reaction still owns escalation; the detailed dispatch is
purely informational follow-up delivery.
* feat: add merge conflict notifications in lifecycle manager
Adds maybeDispatchMergeConflicts() that detects merge conflicts from
the PR enrichment cache or getMergeability() and notifies the worker
session. Conflicts are dispatched independently of session status since
they can coexist with ci_failed, changes_requested, etc.
- Uses the existing merge-conflicts reaction config
- Dispatches once per conflict occurrence (tracks lastMergeConflictDispatched)
- Clears tracking when conflicts resolve, allowing re-dispatch if they recur
- Sends directly via sessionManager.send() (same pattern as CI details)
* fix: use CICheck type instead of inline type declaration
Replace inline Array<{ name, status, url, conclusion }> with the
existing CICheck type from ./types.js for formatCIFailureMessage and
the checks variable in maybeDispatchCIFailureDetails.
* fix: resolve no-useless-assignment lint error in merge conflict check
Declare hasConflicts without initial value since both branches of the
if/else assign to it before it's read.
* feat: show agent notification state in session page blockers
The blockers section on both SessionDetail (IssuesList) and SessionCard
(alert pills) now shows whether the agent has been notified about each
blocker. Reads lifecycle manager dispatch metadata:
- lastCIFailureDispatchHash for CI failures
- lastMergeConflictDispatched for merge conflicts
- lastPendingReviewDispatchHash for review comments
Displays "agent notified" indicator next to blockers where the lifecycle
manager has already forwarded the issue to the worker session.
* fix: use lifecycle status as fallback for blockers when PR data is stale
The blockers section now uses the lifecycle manager's session status
metadata as a source of truth when PR enrichment data hasn't caught up.
PR enrichment uses a 5-min cache and can timeout or be rate-limited,
causing blockers to show stale/incorrect state.
Changes:
- IssuesList and getAlerts now check metadata["status"] (lifecycle
manager state) alongside PR enrichment data
- CI failing: shown when pr.ciStatus is "failing" OR lifecycle status
is "ci_failed"
- Changes requested: shown when pr.reviewDecision matches OR lifecycle
status is "changes_requested"
- Merge conflicts: shown when pr.mergeability.noConflicts is false OR
lifecycle dispatch metadata indicates conflicts were detected
* fix: fall back to getMergeability when cached hasConflicts is undefined
When PREnrichmentData has hasConflicts as undefined (the field is typed
as boolean | undefined), the previous check treated it as no conflicts.
Now falls through to the getMergeability() call instead.
* test: add coverage for CI/conflict notify action and recovery paths
- Test CI tracking clears when CI recovers to passing
- Test notify action for CI failure details (human notification path)
- Test notify action for merge conflicts (human notification path)
These cover the previously uncovered notify action branches and the
CI recovery cleanup path in the lifecycle manager.
* fix: resolve typecheck error in CI recovery test
writeMetadata requires SessionMetadata type which doesn't include
custom keys like lastCIFailureFingerprint. Rewrote the test to use
setupCheck and let the lifecycle manager set tracking metadata
naturally through the CI failure flow, then verify cleanup on recovery.
* fix: don't use dispatch metadata for conflict detection in UI
lastMergeConflictDispatched lingers after conflicts resolve until the
lifecycle manager's next poll clears it. Using it as a conflict signal
caused stale "merge conflict" alerts. Now only pr.mergeability.noConflicts
drives conflict detection; the metadata is only used for the "agent
notified" badge.
* fix: use Promise.allSettled for dispatch functions to avoid orphaned rejections
Promise.all rejects immediately on first failure, leaving in-flight
promises unmonitored. Promise.allSettled waits for all to complete.
harshitsinghbhandari
Harsh Batheja
Dhruv Sharma
Tanuja Nair
Your Name
Tanuu