From e7300c86809381afa15bf3a6ca1a8579a557ad17 Mon Sep 17 00:00:00 2001 From: Florian Pose Date: Tue, 3 May 2016 14:17:39 +0200 Subject: [PATCH] Print mailbox error response data only if data_size > 0. --- master/mailbox.c | 13 +++++++++++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/master/mailbox.c b/master/mailbox.c index 10f47698..3af07bc2 100644 --- a/master/mailbox.c +++ b/master/mailbox.c @@ -178,6 +178,13 @@ uint8_t *ec_slave_mbox_fetch(const ec_slave_t *slave, /**< slave */ return ERR_PTR(-EPROTO); } +#if 0 + if (slave->master->debug_level) { + EC_SLAVE_DBG(slave, 1, "Mailbox data:\n"); + ec_print_data(datagram->data, EC_MBOX_HEADER_SIZE + data_size); + } +#endif + *type = EC_READ_U8(datagram->data + 5) & 0x0F; *size = data_size; @@ -195,11 +202,13 @@ uint8_t *ec_slave_mbox_fetch(const ec_slave_t *slave, /**< slave */ break; } - if (!mbox_msg->code) + if (!mbox_msg->code) { printk("Unknown error reply code 0x%04X.\n", code); + } - if (slave->master->debug_level) + if (slave->master->debug_level && data_size > 0) { ec_print_data(datagram->data + EC_MBOX_HEADER_SIZE, data_size); + } return ERR_PTR(-EPROTO); }