* feat: wire up live activity detection for agent sessions
Previously, all sessions showed as "idle" on the dashboard because
activity detection was never called. The Agent plugin interface has
detectActivity(terminalOutput) and Runtime has getOutput(), but the
session manager's list() and get() methods never invoked them.
Changes:
- Updated list() to call runtime.getOutput() and agent.detectActivity()
after checking if runtime is alive
- Updated get() with the same activity detection logic
- Captures last 30 lines of terminal output for classification
- Falls back to "idle" if output capture fails (graceful degradation)
- Agent plugins classify output into: active, idle, waiting_input,
blocked, or exited
Testing:
- Added test for activity detection in list() with mocked output
- Added test for activity detection in get() with mocked output
- Added test for graceful fallback when getOutput() fails
- Fixed detectActivity mock (sync not async)
- All 24 tests pass
The dashboard now accurately shows whether agents are actively working,
idle at prompt, waiting for user input, blocked, or exited.
Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
* refactor: extract enrichSessionWithRuntimeState helper
Addresses review comment about duplicated activity detection logic
between list() and get() methods.
Changes:
- Extract activity detection into enrichSessionWithRuntimeState helper
- Both list() and get() now call this shared helper
- Eliminates duplication and makes future changes easier
- All tests still pass (24/24)
Benefits:
- Single source of truth for runtime state enrichment
- Future changes (caching, param tweaks) only need one update
- More maintainable and less error-prone
Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
* refactor: replace terminal parsing with agent-native activity detection
Replaces hacky terminal output parsing (detectActivity) with deterministic
agent-native state tracking (getActivityState). Each agent now uses its own
internal mechanisms (JSONL files, SQLite, etc.) for reliable activity detection.
## Changes
### Core (`packages/core/src/types.ts`)
- Add `getActivityState(session)` method to Agent interface
- Deprecate `detectActivity(terminalOutput)` with @deprecated tag
### Session Manager (`packages/core/src/session-manager.ts`)
- Update `enrichSessionWithRuntimeState()` to call `agent.getActivityState()`
- Remove terminal output capture and parsing
- Cleaner, more maintainable code
### Claude Code Plugin (`packages/plugins/agent-claude-code/`)
- Implement `getActivityState()` using existing JSONL infrastructure
- Read last JSONL entry and classify by event type:
- user/tool_use → active
- assistant/system → idle
- permission_request → waiting_input
- error → blocked
- stale (>30s) → idle
- Export `toClaudeProjectPath()` for testing
- Add unit tests for path encoding
### Other Agent Plugins (Codex, Aider, OpenCode)
- Add stub `getActivityState()` implementations
- Fall back to process running check
- TODO comments for full implementation using:
- Codex: JSONL rollout files
- Aider: Chat history mtime
- OpenCode: SQLite database
### Tests (`packages/core/src/__tests__/session-manager.test.ts`)
- Update tests to expect `getActivityState()` calls
- Remove tests for deprecated terminal parsing
- All 24 tests pass ✅
## Benefits
✅ **Deterministic** - File-based, not terminal text parsing
✅ **Fast** - Single file read, no regex
✅ **Reliable** - Agent-provided state
✅ **Testable** - Mock files easily
✅ **Maintainable** - Pin versions, test format changes
## Migration Path
- `detectActivity()` is deprecated but not removed (backwards compat)
- Claude Code uses new method immediately
- Other agents use fallback until fully implemented
- Future PR will remove deprecated method
## Research
Agent-native mechanisms documented in:
- OpenAI Codex: JSONL rollout files at ~/.codex/sessions/
- Aider: Chat history at .aider.chat.history.md
- OpenCode: SQLite at ~/.local/share/opencode/opencode.db
See /tmp/activity-detection-redesign.md for full design.
Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
* feat: implement native activity detection for all agent plugins
Implements full getActivityState() for Codex, Aider, and OpenCode:
- **Codex**: Checks JSONL rollout files at ~/.codex/sessions/YYYY/MM/DD/rollout-*.jsonl
Maps event types (user_message, tool_use, approval_request, error) to activity states
- **Aider**: Checks chat history file mtime at .aider.chat.history.md and recent git commits
Detects activity based on file modification and auto-commit behavior
- **OpenCode**: Checks SQLite database mtime at ~/.local/share/opencode/opencode.db
Considers active if database was modified within 30 seconds
All implementations follow the deterministic approach established for Claude Code,
avoiding hacky terminal output parsing in favor of agent-native mechanisms.
Also fixes test mocks to include new getActivityState() method.
Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
* fix: address bugbot review comments for activity detection
Fixes three issues identified by Cursor Bugbot:
1. **Claude Code returns "exited" when runtime is alive** (Medium)
- Added process-alive check at start of getActivityState()
- Changed fallback returns from "exited" to "active" when process is running
- Now matches pattern used by other agents (Codex, Aider, OpenCode)
2. **Claude Code missing process-alive check** (Medium)
- Added isProcessRunning() check before file-based detection
- Prevents reporting stale file-based activity when process has exited
- Ensures "exited" is only returned when process is actually dead
3. **Codex reads entire JSONL file into memory** (Medium)
- Replaced readFile() with seeked file handle read
- Now reads only last 4KB (TAIL_READ_BYTES) instead of entire file
- Matches efficient approach used by Claude Code plugin
- Prevents memory/latency issues on long-running sessions
All tests passing (85 for Claude Code, 28 for Codex).
Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
* fix: address three additional bugbot review comments
Fixes three issues identified in the second Cursor Bugbot scan:
1. **Catch block doesn't set activity to idle** (Low)
- Added explicit `session.activity = "idle"` in catch block
- Previously relied on implicit default from metadataToSession
- Now explicitly documents and enforces the fallback behavior
2. **Codex rollout file matching uses wrong session ID** (Medium)
- Removed session ID filtering from findLatestRolloutFile()
- Codex uses internal UUIDs unrelated to orchestrator session IDs
- Now finds most recent rollout file across all dates
- Fixes non-functional activity detection for Codex
3. **Duplicate readLastJsonlEntry across packages** (Low)
- Extracted shared JSONL tail-reading logic to @composio/ao-core/utils
- Removed duplicate implementations from agent-claude-code and agent-codex
- Both plugins now import readLastJsonlEntry and TAIL_READ_BYTES from core
- Net reduction of 21 lines while improving maintainability
All 240 tests passing (127 core + 85 Claude Code + 28 Codex).
Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
* fix: remove unused TAIL_READ_BYTES import from claude-code plugin
* fix: address third round of bugbot comments - document agent limitations
Fixes three issues from the latest Cursor Bugbot scan:
1. **Codex reads global state not per-session** (High Severity)
- Removed file-based activity detection from Codex plugin
- Codex stores rollout files globally without workspace scoping
- When multiple sessions run, cannot reliably match files to sessions
- Now falls back to process-running check only (conservative)
- Documented limitation with TODO for when Codex adds per-workspace support
2. **OpenCode uses global shared database** (Medium Severity)
- Removed database mtime checking from OpenCode plugin
- OpenCode uses single global SQLite database for all sessions
- Multiple sessions cause activity state bleed
- Now falls back to process-running check only (conservative)
- Documented limitation with TODO for when OpenCode adds per-workspace support
3. **Unused TAIL_READ_BYTES export** (Low Severity)
- Removed TAIL_READ_BYTES from core package exports
- Only used internally by readLastJsonlEntry in utils.ts
- Reduces unnecessary public API surface
Net reduction: 108 lines of code that couldn't work correctly with multiple sessions.
All tests passing (28 Codex + 27 OpenCode).
Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
* test: rewrite agent integration tests to use getActivityState() instead of detectActivity()
Integration tests were using the deprecated detectActivity() method, which
meant they weren't actually testing the new getActivityState() functionality
that session-manager uses in production.
Changes:
- All agent integration tests now call getActivityState() instead of detectActivity()
- Tests verify getActivityState() returns valid states while running
- Tests verify getActivityState() returns "exited" after process terminates
- Grouped multiple assertions per test run for efficiency
- Updated comments to reflect new behavior (Codex/OpenCode conservative fallback)
- Allow getSessionInfo() to return null for path encoding mismatches
All integration tests pass:
- agent-claude-code: 6 passed (full JSONL-based activity detection)
- agent-codex: 5 passed (conservative fallback)
- agent-opencode: 5 passed (conservative fallback)
- agent-aider: updated but not tested (aider binary not available in CI)
Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
* fix: remove unused imports from integration tests
Fixed ESLint errors:
- Removed unused 'capturePane' imports from all agent integration tests
- Removed unused 'err' variable from catch block
Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
* fix: return active instead of idle when JSONL entry is null
When readLastJsonlEntry returns null (empty file or read error), getActivityState
now returns "active" instead of "idle" as a conservative fallback. This makes it
consistent with:
- Other fallback cases in the same function (no workspace path, no session file)
- Other agent plugins (Codex, OpenCode, Aider) which return "active" on detection failure
- The stated intent in PR discussion to assume active when process is running
Fixes bugbot comment: https://github.com/ComposioHQ/agent-orchestrator/pull/45#discussion_r2810110669
Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
* fix: make TAIL_READ_BYTES internal constant instead of exported
TAIL_READ_BYTES is only used internally within readLastJsonlEntry()
and is not exported from the package's index.ts. Removed the export
keyword to make it clear it's an internal implementation detail.
Addresses bugbot comment about unused export.
Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
---------
Co-authored-by: Claude Sonnet 4.5 <noreply@anthropic.com>
79aac7cf1d