agent-orchestrator/backend/internal/cli/hooks.go

126 lines
4.6 KiB
Go

package cli
import (
"context"
"fmt"
"io"
"net/url"
"os"
"path/filepath"
"regexp"
"strings"
"time"
"github.com/spf13/cobra"
"github.com/aoagents/agent-orchestrator/backend/internal/adapters/agent/activitydispatch"
)
// sessionIDPattern bounds the AO_SESSION_ID we will place in a request path to
// the id alphabet the daemon issues. Validating the externally-set env value
// before it reaches the loopback URL keeps it from steering the request.
var sessionIDPattern = regexp.MustCompile(`^[A-Za-z0-9_-]+$`)
const (
// hooksLogName is the file under AO_DATA_DIR where hook delivery failures
// are appended. Agent hook runners swallow stderr, so without a durable
// sink a dead activity feed (e.g. an unreachable daemon) stays invisible.
hooksLogName = "hooks.log"
// maxHooksLogBytes caps hooks.log: an append against a file already past
// the cap truncates it first, so a persistently failing hook cannot grow
// the file without bound.
maxHooksLogBytes = 1 << 20
)
// setActivityAPIRequest mirrors the daemon's SetActivityRequest body for
// POST /api/v1/sessions/{id}/activity. The CLI keeps its own copy so it need
// not import httpd.
type setActivityAPIRequest struct {
State string `json:"state"`
}
// newHooksCommand builds the hidden `ao hooks <agent> <event>` command that
// agent CLIs invoke from their workspace-local hook config. It reads the native
// hook payload from stdin and the AO session id from AO_SESSION_ID, derives an
// activity state for the event, and reports it to the daemon.
//
// It is best-effort by design: a hook must never break the user's agent, so a
// non-AO session (no AO_SESSION_ID), an event that carries no activity signal,
// or an unreachable daemon all exit 0 rather than erroring.
func newHooksCommand(ctx *commandContext) *cobra.Command {
return &cobra.Command{
Use: "hooks <agent> <event>",
Short: "Receive an agent hook callback (internal)",
Hidden: true,
Args: cobra.ExactArgs(2),
RunE: func(cmd *cobra.Command, args []string) error {
return ctx.runHook(cmd.Context(), args[0], args[1])
},
}
}
func (c *commandContext) runHook(ctx context.Context, agent, event string) error {
sessionID := strings.TrimSpace(os.Getenv("AO_SESSION_ID"))
if !sessionIDPattern.MatchString(sessionID) {
// Not an AO-managed session (unset/empty), or an id we won't put in a
// request path. Return before reading stdin so a manual invocation
// without a piped payload can't block on EOF.
return nil
}
payload, err := io.ReadAll(c.deps.In)
if err != nil {
// Surface read errors for parity with the daemon-error path, but keep
// the empty payload and exit 0: a failed hook must not break the
// agent. The deriver tolerates an empty payload.
c.reportHookFailure(agent, event, sessionID, fmt.Errorf("read stdin: %w", err))
}
state, ok := activitydispatch.Derive(agent, event, payload)
if !ok {
// Unknown agent, or an event that carries no activity signal: report nothing.
return nil
}
path := "sessions/" + url.PathEscape(sessionID) + "/activity"
if err := c.postJSON(ctx, path, setActivityAPIRequest{State: string(state)}, nil); err != nil {
// Surface the failure for diagnosis, but exit 0: a failed activity
// report must not disrupt the agent.
c.reportHookFailure(agent, event, sessionID, err)
}
return nil
}
// reportHookFailure surfaces a hook delivery failure without breaking the
// agent: stderr for the agent's hook runner, plus a best-effort append to
// $AO_DATA_DIR/hooks.log so the failure can be diagnosed after the fact.
func (c *commandContext) reportHookFailure(agent, event, sessionID string, cause error) {
msg := fmt.Sprintf("ao hooks %s %s: %v", agent, event, cause)
_, _ = fmt.Fprintln(c.deps.Err, msg)
dataDir := strings.TrimSpace(os.Getenv("AO_DATA_DIR"))
if dataDir == "" {
return
}
line := fmt.Sprintf("%s session=%s %s\n", time.Now().UTC().Format(time.RFC3339), sessionID, msg)
appendHooksLog(dataDir, line)
}
// appendHooksLog appends one line to the hooks log, truncating first when the
// file has outgrown maxHooksLogBytes. Errors are dropped: this sink is itself
// best-effort and has nowhere better to report.
func appendHooksLog(dataDir, line string) {
if err := os.MkdirAll(dataDir, 0o750); err != nil {
return
}
path := filepath.Join(dataDir, hooksLogName)
flags := os.O_APPEND | os.O_CREATE | os.O_WRONLY
if info, err := os.Stat(path); err == nil && info.Size() > maxHooksLogBytes {
flags = os.O_TRUNC | os.O_CREATE | os.O_WRONLY
}
f, err := os.OpenFile(path, flags, 0o600) //nolint:gosec // path is rooted in AO's own data dir
if err != nil {
return
}
defer func() { _ = f.Close() }()
_, _ = f.WriteString(line)
}