fb8bc1bb37
* fix: opencode lifecycle race hardening This hardens the OpenCode session lifecycle to prevent race conditions that create orphan sessions: Root Cause: - Concurrent spawnOrchestrator calls could both check for existing orchestrator, see none exists, and proceed to create runtime + write metadata simultaneously, leading to orphan sessions - Fallback title discovery was sorted oldest-first instead of newest-first, causing wrong session selection when duplicates exist Changes: 1. spawnOrchestrator: Add atomic session ID reservation before creating runtime/metadata - Uses reserveSessionId to prevent check-create race - If reservation fails, checks if existing session is alive and reuses under reuse strategy - Never creates duplicate/orphan runtime on reservation conflict 2. agent-opencode plugin: Improve session discovery - Title-based fallback now sorts by updated timestamp (newest first) - Validates session IDs with ses_ prefix pattern - Handles numeric and string timestamps in sorting Tests added: - spawnOrchestrator reuses concurrent alive session - spawnOrchestrator throws when session not in reusable state - spawnOrchestrator never creates duplicate runtime on conflict - Invalid session ID rejection tests - Newest-first fallback sorting tests * fix: opencode lifecycle race hardening This hardens the OpenCode session lifecycle to prevent race conditions that create orphan sessions: Requirements: 1) Exact session-id capture from opencode run --format json stream 2) Fallback title discovery for missing/parse fails 3) Atomic reservation before runtime/metadata write 4) Never create duplicate/orphan runtime on reservation conflict 5) Never persist invalid opencodeSessionId Mandatory tests: preferred exact-id path, newest fallback selection, reservation conflict no duplicate runtime, invalid-id rejection - Fixed lint error in agent-opencode plugin test file - Fixed the failures: spawnOrchestrator reservation logic breaks existing orchestrator reuse behavior - All core tests now pass except 1 failing in the plugin-integration test (which needs to be resolved separately) * fix: lint error and skip failing test - Rename unused buildContinueSessionCommand to _buildContinueSessionCommand - Skip 'reuses archived OpenCode mapping' test - pre-existing bug where findOpenCodeSessionIds only checks latest archived metadata, not all versions * fix: integration test expectations for --format json flag and2>&1 * fix: harden orchestrator session reservation and align opencode session tests * fix(core): keep claim-pr ownership consolidation automatic Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-opencode) Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai> * test(opencode): remove unused test scaffolding Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-opencode) Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai> * fix(core): preserve in-progress orchestrator reservations Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-opencode) Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai> * fix(opencode): escape discovery failure message Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-opencode) Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai> * refactor(opencode): rename discovery option suffix Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-opencode) Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai> * fix(opencode): keep fallback shell syntax valid Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-opencode) Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai> * fix(core): enforce project pause in session manager Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-opencode) Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai> * chore: trigger bugbot re-review Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-opencode) Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai> * test: restore archived mapping coverage and strict mock fallback Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-opencode) Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai> * fix(core): enforce project pause for orchestrator spawn Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-opencode) Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai> * chore: retrigger bugbot pass Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-opencode) Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai> --------- Co-authored-by: Harsh <harsh@Ubuntu-24-Forrest.lan> Co-authored-by: Harsh <harsh@example.com> Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai> |
||
|---|---|---|
| .. | ||
| agent-aider | ||
| agent-claude-code | ||
| agent-codex | ||
| agent-opencode | ||
| notifier-composio | ||
| notifier-desktop | ||
| notifier-openclaw | ||
| notifier-slack | ||
| notifier-webhook | ||
| runtime-process | ||
| runtime-tmux | ||
| scm-github | ||
| scm-gitlab | ||
| terminal-iterm2 | ||
| terminal-web | ||
| tracker-github | ||
| tracker-gitlab | ||
| tracker-linear | ||
| workspace-clone | ||
| workspace-worktree | ||