* fix: serialize ao start and stop numbered orchestrators (#1306) * fix: restore dead orchestrators on start (#1306) * fix: harden startup lock handling (#1306) * feat(core): enrich events with PR title, description, and URL Adds PR and issue context to all event payloads sent to notifiers. External consumers (Telegram, Discord, n8n) can now display meaningful information without making additional API calls. Changes: - Add buildEventContext() helper to extract PR/issue context from session - Enrich all createEvent() calls with context data (pr, issueId, issueTitle, branch) - Store issueTitle in session metadata during spawn - Add issueTitle field to SessionMetadata interface - Update executeReaction() to accept session for context access - Add tests for event enrichment The context includes: - pr: { url, title, number, branch } when PR exists - issueId: issue identifier - issueTitle: issue title (from tracker during spawn) - branch: session branch name Events before PR creation gracefully omit PR fields (pr: null). Existing webhook consumers that ignore unknown fields are unaffected. Closes #1226 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * fix(core): address review comments for event enrichment - Add issueTitle to readMetadata/writeMetadata for proper persistence - Create ReactionSessionContext type for type-safe system events - Replace unsafe `as unknown as Session` cast with proper union type - Add end-to-end test verifying issueTitle persistence during spawn Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * fix(cli): include lock file path in startup lock error message Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * fix: address review feedback — fd safety, kill-all resilience, issueTitle restore - Restore try/catch/finally in tryAcquire for fd leak prevention - Wrap stop command's sm.list()+kill in try/catch so dashboard shutdown always runs even on session listing failure - Add per-iteration error handling in kill-all loop with partial failure reporting (spinner.warn for mixed results) - Unify allSessionPrefixes derivation between start and stop commands - Propagate issueTitle through archive restore path - Add clarifying comments on agentInfo.summary fallback and intentional prNumber/prUrl duplication in event data - Add ora warn mock for stop tests - Update changeset to minor (event enrichment is a feature) and add CLI changeset for stop resilience - Add tests for kill-all error mid-loop and issueTitle archive restore Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * fix: address harsh-batheja review — title/summary split, lock grace, context namespace - Separate PR title from agent summary in EventContext: title is null until enrichment cache populates; summary is a distinct field so webhook consumers never confuse the task summary for a PR title. - Restore UNPARSEABLE_LOCK_GRACE_MS (5s mtime grace) and isStaleUnparseableLock lost during merge conflict resolution — prevents lockfile-steal race when process A just created the file but hasn't written metadata yet. - Fix orchestrator sort: extract numeric suffix instead of localeCompare so -10 sorts after -2, not before. - Namespace context under data.context instead of spreading into data to prevent field collisions with reaction-specific keys. - Add schemaVersion: 2 to all enriched events so consumers can migrate away from top-level prNumber/prUrl (kept for compat, marked for removal in v3). - Update event enrichment tests for nested context structure. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * fix: resolve merge conflicts — use formatReviewCommentsMessage, fix batch enrichment mock - Replace formatAutomatedCommentsMessage with upstream's formatReviewCommentsMessage for automated review comment dispatch (fixes type mismatch with ReviewComment[]) - Make createMockSCM's enrichSessionsPRBatch dynamically resolve from individual method mocks so test overrides (e.g. getPRState("closed")) propagate correctly - Add explicit enrichSessionsPRBatch to merge-conflict-tracking test to avoid unexpected getMergeability calls from the dynamic mock - Remove all debug console.log statements added during troubleshooting Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * fix: wire up maybeDispatchCIFailureDetails and record dispatch hash on transition The function was defined but never called after merge conflict resolution dropped the call site. Added it back to the Promise.allSettled alongside maybeDispatchReviewBacklog and maybeDispatchMergeConflicts. Also updated the transition-reaction early-return to record the dispatch hash, since the transition path now enriches the CI message with detailed check info from the batch cache — preventing duplicate sends on subsequent polls. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * test: remove stale duplicate test from rebase Removes the orphaned numbered-orchestrator restoration test left over from feat/1226 history. Upstream's canonical model test (same name, expects "app-orchestrator" via ensureOrchestrator) supersedes it. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> * docs: remove misleading CLI CHANGELOG entry The "Restore the most recently active dead orchestrator on ao start" entry described upstream's ensureOrchestrator behavior (#1487), not work contributed by this PR. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> * docs(changeset): correct scope and drop stale CLI changeset - Rewrite the @aoagents/ao-core changeset to describe only what feat/1226 contributes: event enrichment with schemaVersion: 2, issueTitle persistence, executeReaction refactor, maybeDispatchCIFailureDetails, and bugbot-comments enrichment. Drop the false claims about adding spawn-target and format-automated-comments (those modules came from upstream PRs #1330 and #1334). - Delete stop-kill-all-resilience.md — its claims (kill-all loop, fd-safety in tryAcquire, allSessionPrefixes unify) are no longer in the branch after the rebase took upstream's canonical stop logic. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com> |
||
|---|---|---|
| .. | ||
| __tests__ | ||
| src | ||
| CHANGELOG.md | ||
| README.md | ||
| package.json | ||
| rollup.config.ts | ||
| tsconfig.build.json | ||
| tsconfig.json | ||
| vitest.config.ts | ||
README.md
@aoagents/ao-core
Core services, types, and configuration for the Agent Orchestrator system.
What's Here
src/types.ts— All TypeScript interfaces (Runtime, Agent, Workspace, Tracker, SCM, Notifier, Terminal, Session, events)src/services/— Core services (SessionManager, LifecycleManager, PluginRegistry)src/config.ts— Configuration loading + Zod schemassrc/utils/— Shared utilities (shell escaping, metadata parsing, etc.)
Key Files
src/types.ts — The Source of Truth
Every interface the system uses is defined here. If you're working on any part of the orchestrator, start by reading this file.
Main interfaces:
Runtime— where sessions execute (tmux, docker, k8s)Agent— AI coding tool adapter (claude-code, codex, aider)Workspace— code isolation (worktree, clone)Tracker— issue tracking (GitHub Issues, Linear)SCM— PR/CI/reviews (GitHub, GitLab)Notifier— push notifications (desktop, Slack, webhook)Terminal— human interaction UI (iTerm2, web)Session— running agent instance (state, metadata, handles)OrchestratorEvent— events emitted by lifecycle managerPluginModule— what every plugin exports
src/services/session-manager.ts — Session CRUD
Handles session lifecycle:
spawn(config)— create new session (workspace + runtime + agent)list(projectId?)— list all sessionsget(sessionId)— get session detailskill(sessionId)— terminate sessioncleanup(projectId?)— kill completed/merged sessionssend(sessionId, message)— send message to agent
Data flow in spawn():
- Load project config
- Validate issue exists via
Tracker.getIssue()(if issueId provided, fails-fast if not found) - Reserve session ID
- Determine branch name
- Create workspace via
Workspace.create() - Generate prompt via
Tracker.generatePrompt() - Build layered worker prompt via
buildPrompt()intosystemPrompt+taskPrompt - Persist
systemPromptFilefor the session and, for OpenCode workers, writeOPENCODE_CONFIG - Build launch command via
Agent.getLaunchCommand() - Create runtime session via
Runtime.create() - Run
Agent.postLaunchSetup()(optional) - Write metadata file
- Return Session object
Note: If issue validation fails (not found, auth error), spawn fails before creating any resources (no workspace, no runtime, no session ID). This prevents spawning sessions with broken issue references.
Worker sessions keep persistent instructions in the prompt file. OpenCode workers consume that file through OPENCODE_CONFIG, while OpenCode orchestrators continue to project their system prompt into workspace AGENTS.md.
src/services/lifecycle-manager.ts — State Machine + Reactions
Polls sessions, detects state changes, triggers reactions:
State machine:
spawning → working → pr_open → ci_failed/review_pending/approved → mergeable → merged
Reactions:
ci-failed→ send fix prompt to agentchanges-requested→ send review comments to agentapproved-and-green→ notify human (or auto-merge)agent-stuck→ notify human
Polling loop:
- For each session: check agent activity state (
Agent.getActivityState()) - If PR exists: check CI status (
SCM.getCISummary()), review state (SCM.getReviewDecision()) - Update session status based on state
- Trigger reactions if state changed
- Emit events
src/services/plugin-registry.ts — Plugin Discovery + Loading
Loads plugins and provides access to them:
register(plugin, config?)— register a plugin instanceget<T>(slot, name)— get plugin by slot + namelist(slot)— list all plugins for a slotloadBuiltins(config?)— load built-in plugins (runtime-tmux, agent-claude-code, etc.)loadFromConfig(config)— load built-ins today; external plugin descriptors are the marketplace extension point
Built-in plugins (loaded by default):
- runtime-tmux, runtime-process
- agent-claude-code, agent-codex, agent-aider, agent-cursor, agent-kimicode, agent-opencode
- workspace-worktree, workspace-clone
- tracker-github, tracker-linear, tracker-gitlab
- scm-github, scm-gitlab
- notifier-desktop, notifier-discord, notifier-slack, notifier-composio, notifier-openclaw, notifier-webhook
- terminal-iterm2, terminal-web
src/config.ts — Configuration Loading
Loads and validates agent-orchestrator.yaml:
Main config sections:
- Runtime data paths are auto-derived from the config location under
~/.agent-orchestrator/{hash}-{projectId}/ port— web dashboard port (default 3000, set different values for multiple projects)terminalPort— terminal WebSocket port (auto-detected if not set)directTerminalPort— direct terminal WebSocket port (auto-detected if not set)defaults— default plugins (runtime, agent, workspace, notifiers)plugins— installer-managed external plugin descriptors (registry, npm, or local)projects— per-project config (repo, path, branch, symlinks, reactions, agentRules)notifiers— notification channel config (Slack webhooks, etc.)notificationRouting— which notifiers get which priority eventsreactions— auto-response config (ci-failed, changes-requested, approved-and-green, etc.)
Zod schemas validate all config at load time.
Common Tasks
Adding a Field to Session
- Edit
src/types.ts→Sessioninterface - Edit
src/services/session-manager.ts→ initialize field inspawn() - Rebuild:
pnpm --filter @aoagents/ao-core build
Adding an Event Type
- Edit
src/types.ts→EventTypeunion - Emit the event:
eventEmitter.emit()in relevant service - Add reaction handler (optional):
src/services/lifecycle-manager.ts
Adding a Reaction
- Edit
src/services/lifecycle-manager.ts→ add handler function - Wire it up in the polling loop
- Add config schema in
src/config.tsif new reaction type
Feedback Tools (v1)
@aoagents/ao-core exports two structured feedback tool contracts:
bug_reportimprovement_suggestion
Both share the same required input fields:
titlebodyevidence(array of strings)sessionsourceconfidence(0..1)
Example:
import { FEEDBACK_TOOL_NAMES, FeedbackReportStore, getFeedbackReportsDir } from "@aoagents/ao-core";
const reportsDir = getFeedbackReportsDir(configPath, projectPath);
const store = new FeedbackReportStore(reportsDir);
const saved = store.persist(FEEDBACK_TOOL_NAMES.BUG_REPORT, {
title: "SSO login loop",
body: "Google SSO redirects back to /login repeatedly.",
evidence: ["trace_id=abc123", "screenshot: login-loop.png"],
session: "ao-22",
source: "agent",
confidence: 0.84,
});
Storage format:
- Reports are persisted under
~/.agent-orchestrator/{hash}-{projectId}/feedback-reports - Each report is a typed key=value file (
report_<timestamp>_<id>.kv) for easy inspection - A deterministic dedupe key (
sha256, 16 hex chars) is generated from normalized tool+content
Migration notes:
- No migration needed for existing AO installs
- The
feedback-reportsdirectory is created lazily on first persisted report
Testing
# Run all core tests
pnpm --filter @aoagents/ao-core test
# Run in watch mode
pnpm --filter @aoagents/ao-core test -- --watch
# Run specific test
pnpm --filter @aoagents/ao-core test -- session-manager.test.ts
Tests are in src/__tests__/:
session-manager.test.ts— session CRUD, spawn, cleanuplifecycle-manager.test.ts— state machine, reactionsplugin-registry.test.ts— plugin loading, resolutiontmux.test.ts— tmux utility functions (not a plugin test)prompt-builder.test.ts— prompt generation utilities
Building
# Build core
pnpm --filter @aoagents/ao-core build
# Typecheck
pnpm --filter @aoagents/ao-core typecheck
This package is a dependency of all other packages. Build it first if working on the codebase.
Architecture Notes
Why flat metadata files?
- Debuggability:
cat ~/.agent-orchestrator/<hash>-my-app/sessions/app-3shows full state - No database dependency (survives crashes, easy to inspect)
- Backwards-compatible with bash script orchestrator
Why polling instead of webhooks?
- Simpler (no webhook setup, no ngrok for local dev)
- Works offline (CI/review state is fetched, not pushed)
- Survives orchestrator restarts (no missed events)
Why plugin slots?
- Swappability: use tmux locally, docker in CI, k8s in prod
- Testability: mock plugins for tests
- Extensibility: users can add custom plugins (e.g., company-specific notifier)