* feat(web): collapse attention zones to 4 with feature flag for 5 (#1201) Simplify the dashboard to a 4-zone kanban by default (WORKING, PENDING, ACTION, READY), merging the former REVIEW + RESPOND columns into a single ACTION zone that just asks "does the human need to do something?". The card-level badges still surface the underlying granular state (ci_failed, needs_input, changes_requested), so nothing is lost — it just moves off the column header. Add a `dashboard.attentionZones` config (defaults to "simple") that opts back into the original 5-zone layout for power users. The function-level `getAttentionLevel(session, mode)` still defaults to "detailed" so card-level call sites (SessionCard, BottomSheet, ProjectSidebar, etc.) keep their granular behavior untouched. Only the Dashboard kanban and SSE server routes read the config and pass the mode. Closes #1201 * fix(web): address PR review feedback on attention zones (#1201) - Drop .strict() from DashboardConfigSchema (Cursor Bugbot): matches other schemas in config.ts so typos in the dashboard block gracefully default instead of crashing the whole loader. - DynamicFavicon: keep `action` at yellow, not red (Codex P2). In simple mode, `action` collapses respond + review, which means it necessarily catches routine review work (ci_failed, changes_requested) that was previously yellow. Escalating to red would make every typical PR scream critical. Only the detailed-mode `respond` bucket still triggers red. - useSessionEvents default → "detailed" (Codex P3). The hook default now matches getAttentionLevel's default so callers that seed with `getAttentionLevel(s)` (no mode) — notably PullRequestsPage — stay consistent with their seed after the first live SSE/refresh snapshot. Dashboard explicitly passes the config's attentionZones to opt into simple mode. - Expand mobile action chip (Codex P3). When a session collapses to `action`, derive the most specific underlying cause (needs input, stuck, errored, ci failed, changes, waiting, conflicts) instead of falling through to the generic "action" label, so mobile users keep the reason to intervene. - DynamicFavicon tests: add cases for `action` staying yellow and `respond` still escalating when both are present. * fix(web): thread attentionZones config through PullRequestsPage (#1201) Cursor Bugbot caught a deeper version of the same inconsistency my previous fix didn't fully resolve: the server SSE route uses `config.dashboard?.attentionZones ?? "simple"`, but PullRequestsPage was seeding `initialAttentionLevels` and calling useSessionEvents without passing any mode (falling back to the hook's "detailed" default). Result: snapshots from the server arrived as "action"/ "merge", then scheduleRefresh recomputed them client-side as "respond"/"review", and the favicon oscillated between yellow and red on every refresh cycle. Fix: plumb pageData.attentionZones through prs/page.tsx into PullRequestsPage, use it in both the seed and useSessionEvents. Now the seed, the server SSE, and the client refresh all use the same mode — stable, no flicker. * fix(web): accurate action labels for crashed agents + yellow tone (#1201) Two Cursor Bugbot findings on the action-zone collapse work: 1. [Medium] Mobile chip mislabeled crashed agents as "needs input". When an agent's activity is `exited` and the session is in the action bucket, the agent has crashed — sending it a message won't help, the user needs to restart. Split the label: exited → "crashed", blocked → "blocked". 2. [Low] ProjectMetric for Action used tone="error" (red), which contradicts the favicon fix's rationale. The action bucket catches routine review work (ci_failed, changes_requested) that was previously orange/yellow severity; screaming red in the project overview grid would have the same cry-wolf problem as the favicon did. Use tone="orange" (the less severe of the two merged buckets) to match. * refactor(web): make attentionZones required in useSessionEvents (#1201) Cursor Bugbot caught that the hook default of "detailed" mismatches the server SSE route default of "simple" — a latent footgun for any future caller that forgets to pass the mode explicitly. The exact oscillation bug I already fixed once for PullRequestsPage would silently come back on the next page that uses this hook. Real fix: refactor the hook to take an options object and make `attentionZones` required with no default. TypeScript now enforces that every caller explicitly passes the mode the server is using. You literally cannot call useSessionEvents without supplying it. Also cleaner: the hook had 6 positional parameters, which is past the point where an options object helps readability. Dashboard and PullRequestsPage call sites now read as self-documenting. * fix(web): address human code review on attention zones (#1201) Review from i-trytoohard on commit 8d27db79: 1. [Medium] `ZoneCounts` in sessions/[id]/page.tsx had an `action` field that was always 0 — the page always computes in detailed mode (getAttentionLevel with no mode = detailed), and the consumer (`OrchestratorZones` in SessionDetail) never reads an `action` field either. Removed the dead field, added a `continue` guard for the never-reached "action" case so TypeScript narrows the index correctly, and documented the intent in a header comment. 2. [Medium] The simple-mode action chip had 10+ sub-conditions with no tests. Extracted the label logic into a pure `getActionChipLabel(session)` helper and added 16 unit tests covering every branch: status-based signals (needs_input, stuck, errored, ci_failed, changes_requested), activity-based (waiting_input, exited→crashed, blocked), PR-based (failing CI, changes_requested, conflicts), precedence between signal classes, and the generic fallback. 3. [Low] `LEVEL_LABELS.action` in ProjectSidebar is dead code today (sidebar uses detailed mode). Added a comment explaining why the entry still exists (TypeScript exhaustiveness on `Record<AttentionLevel, string>` + forward-compat). * fix(web): address inline review on attention zones (#1201) - Reorder getActionChipLabel to mirror getDetailedAttentionLevel: respond-class activity (waiting_input/exited/blocked) now outranks review-class status (ci_failed/changes_requested). A crashed agent with changes_requested no longer reads as "changes" and hides the crash. - Paint data-level="action" dot with --color-accent-orange to match the favicon's yellow-severity treatment of the collapsed bucket. - Tighten attentionLevel on the mux boundary (mux-protocol, mux-websocket, useSessionEvents) from string to AttentionLevel so invalid values like "none" no longer launder through into DynamicFavicon's count. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com> |
||
|---|---|---|
| .. | ||
| __tests__ | ||
| src | ||
| CHANGELOG.md | ||
| README.md | ||
| package.json | ||
| rollup.config.ts | ||
| tsconfig.build.json | ||
| tsconfig.json | ||
| vitest.config.ts | ||
README.md
@aoagents/ao-core
Core services, types, and configuration for the Agent Orchestrator system.
What's Here
src/types.ts— All TypeScript interfaces (Runtime, Agent, Workspace, Tracker, SCM, Notifier, Terminal, Session, events)src/services/— Core services (SessionManager, LifecycleManager, PluginRegistry)src/config.ts— Configuration loading + Zod schemassrc/utils/— Shared utilities (shell escaping, metadata parsing, etc.)
Key Files
src/types.ts — The Source of Truth
Every interface the system uses is defined here. If you're working on any part of the orchestrator, start by reading this file.
Main interfaces:
Runtime— where sessions execute (tmux, docker, k8s)Agent— AI coding tool adapter (claude-code, codex, aider)Workspace— code isolation (worktree, clone)Tracker— issue tracking (GitHub Issues, Linear)SCM— PR/CI/reviews (GitHub, GitLab)Notifier— push notifications (desktop, Slack, webhook)Terminal— human interaction UI (iTerm2, web)Session— running agent instance (state, metadata, handles)OrchestratorEvent— events emitted by lifecycle managerPluginModule— what every plugin exports
src/services/session-manager.ts — Session CRUD
Handles session lifecycle:
spawn(config)— create new session (workspace + runtime + agent)list(projectId?)— list all sessionsget(sessionId)— get session detailskill(sessionId)— terminate sessioncleanup(projectId?)— kill completed/merged sessionssend(sessionId, message)— send message to agent
Data flow in spawn():
- Load project config
- Validate issue exists via
Tracker.getIssue()(if issueId provided, fails-fast if not found) - Reserve session ID
- Determine branch name
- Create workspace via
Workspace.create() - Generate prompt via
Tracker.generatePrompt() - Build launch command via
Agent.getLaunchCommand() - Create runtime session via
Runtime.create() - Run
Agent.postLaunchSetup()(optional) - Write metadata file
- Return Session object
Note: If issue validation fails (not found, auth error), spawn fails before creating any resources (no workspace, no runtime, no session ID). This prevents spawning sessions with broken issue references.
src/services/lifecycle-manager.ts — State Machine + Reactions
Polls sessions, detects state changes, triggers reactions:
State machine:
spawning → working → pr_open → ci_failed/review_pending/approved → mergeable → merged
Reactions:
ci-failed→ send fix prompt to agentchanges-requested→ send review comments to agentapproved-and-green→ notify human (or auto-merge)agent-stuck→ notify human
Polling loop:
- For each session: check agent activity state (
Agent.getActivityState()) - If PR exists: check CI status (
SCM.getCISummary()), review state (SCM.getReviewDecision()) - Update session status based on state
- Trigger reactions if state changed
- Emit events
src/services/plugin-registry.ts — Plugin Discovery + Loading
Loads plugins and provides access to them:
register(plugin, config?)— register a plugin instanceget<T>(slot, name)— get plugin by slot + namelist(slot)— list all plugins for a slotloadBuiltins(config?)— load built-in plugins (runtime-tmux, agent-claude-code, etc.)loadFromConfig(config)— load built-ins today; external plugin descriptors are the marketplace extension point
Built-in plugins (loaded by default):
- runtime-tmux, runtime-process
- agent-claude-code, agent-codex, agent-aider, agent-opencode
- workspace-worktree, workspace-clone
- tracker-github, tracker-linear, tracker-gitlab
- scm-github, scm-gitlab
- notifier-desktop, notifier-discord, notifier-slack, notifier-composio, notifier-openclaw, notifier-webhook
- terminal-iterm2, terminal-web
src/config.ts — Configuration Loading
Loads and validates agent-orchestrator.yaml:
Main config sections:
- Runtime data paths are auto-derived from the config location under
~/.agent-orchestrator/{hash}-{projectId}/ port— web dashboard port (default 3000, set different values for multiple projects)terminalPort— terminal WebSocket port (auto-detected if not set)directTerminalPort— direct terminal WebSocket port (auto-detected if not set)defaults— default plugins (runtime, agent, workspace, notifiers)plugins— installer-managed external plugin descriptors (registry, npm, or local)projects— per-project config (repo, path, branch, symlinks, reactions, agentRules)notifiers— notification channel config (Slack webhooks, etc.)notificationRouting— which notifiers get which priority eventsreactions— auto-response config (ci-failed, changes-requested, approved-and-green, etc.)
Zod schemas validate all config at load time.
Common Tasks
Adding a Field to Session
- Edit
src/types.ts→Sessioninterface - Edit
src/services/session-manager.ts→ initialize field inspawn() - Rebuild:
pnpm --filter @aoagents/ao-core build
Adding an Event Type
- Edit
src/types.ts→EventTypeunion - Emit the event:
eventEmitter.emit()in relevant service - Add reaction handler (optional):
src/services/lifecycle-manager.ts
Adding a Reaction
- Edit
src/services/lifecycle-manager.ts→ add handler function - Wire it up in the polling loop
- Add config schema in
src/config.tsif new reaction type
Feedback Tools (v1)
@aoagents/ao-core exports two structured feedback tool contracts:
bug_reportimprovement_suggestion
Both share the same required input fields:
titlebodyevidence(array of strings)sessionsourceconfidence(0..1)
Example:
import { FEEDBACK_TOOL_NAMES, FeedbackReportStore, getFeedbackReportsDir } from "@aoagents/ao-core";
const reportsDir = getFeedbackReportsDir(configPath, projectPath);
const store = new FeedbackReportStore(reportsDir);
const saved = store.persist(FEEDBACK_TOOL_NAMES.BUG_REPORT, {
title: "SSO login loop",
body: "Google SSO redirects back to /login repeatedly.",
evidence: ["trace_id=abc123", "screenshot: login-loop.png"],
session: "ao-22",
source: "agent",
confidence: 0.84,
});
Storage format:
- Reports are persisted under
~/.agent-orchestrator/{hash}-{projectId}/feedback-reports - Each report is a typed key=value file (
report_<timestamp>_<id>.kv) for easy inspection - A deterministic dedupe key (
sha256, 16 hex chars) is generated from normalized tool+content
Migration notes:
- No migration needed for existing AO installs
- The
feedback-reportsdirectory is created lazily on first persisted report
Testing
# Run all core tests
pnpm --filter @aoagents/ao-core test
# Run in watch mode
pnpm --filter @aoagents/ao-core test -- --watch
# Run specific test
pnpm --filter @aoagents/ao-core test -- session-manager.test.ts
Tests are in src/__tests__/:
session-manager.test.ts— session CRUD, spawn, cleanuplifecycle-manager.test.ts— state machine, reactionsplugin-registry.test.ts— plugin loading, resolutiontmux.test.ts— tmux utility functions (not a plugin test)prompt-builder.test.ts— prompt generation utilities
Building
# Build core
pnpm --filter @aoagents/ao-core build
# Typecheck
pnpm --filter @aoagents/ao-core typecheck
This package is a dependency of all other packages. Build it first if working on the codebase.
Architecture Notes
Why flat metadata files?
- Debuggability:
cat ~/.agent-orchestrator/<hash>-my-app/sessions/app-3shows full state - No database dependency (survives crashes, easy to inspect)
- Backwards-compatible with bash script orchestrator
Why polling instead of webhooks?
- Simpler (no webhook setup, no ngrok for local dev)
- Works offline (CI/review state is fetched, not pushed)
- Survives orchestrator restarts (no missed events)
Why plugin slots?
- Swappability: use tmux locally, docker in CI, k8s in prod
- Testability: mock plugins for tests
- Extensibility: users can add custom plugins (e.g., company-specific notifier)