f3224e9193
Address critical PR review findings from #1076. ## Changes ### Critical Fix - **cursor/index.ts:308**: Add required parameters to getRestoreCommand signature - Was: `async getRestoreCommand(): Promise<string | null>` - Now: `async getRestoreCommand(_session: Session, _project: ProjectConfig): Promise<string | null>` - Fixes interface contract violation that would cause silent runtime failures - Parameters prefixed with _ since method always returns null (Cursor doesn't support resume) ### Documentation Improvements - **cursor/index.ts:125-127**: Add comment explaining --auto-approve flag - Clarifies that --auto-approve is equivalent to Aider's --yes flag - Maps to same permission semantics across agents - **cli/config-instruction.ts:24,144**: Add cursor to available agents list - Update defaults example to include cursor - Update "Available plugins" reference to include cursor ### Type Imports - **cursor/index.ts:19**: Import ProjectConfig type for getRestoreCommand signature ## Testing - ✅ cursor plugin tests: 51/51 passing - ✅ cursor plugin typecheck: clean - ✅ No regressions introduced ## Why These Changes Are Needed **Before:** - getRestoreCommand signature mismatch would cause silent failures when core system calls it with parameters - Config documentation didn't mention cursor as available agent option - No explanation why --auto-approve differs from Aider's --yes naming **After:** - Interface contract properly satisfied - Documentation complete and helpful - Clear code comments explaining design decisions Addresses: ComposioHQ/agent-orchestrator#1076 Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com> |
||
|---|---|---|
| .. | ||
| __tests__ | ||
| src | ||
| templates/rules | ||
| CHANGELOG.md | ||
| package.json | ||
| tsconfig.json | ||
| vitest.config.ts | ||