04f3a7c27f
Address PR review feedback from #1076 to make Cursor agent fully functional. ## Changes ### Plugin Registration (High Severity Fixes) - **core/plugin-registry.ts**: Add cursor to BUILTIN_PLUGINS array for config-based resolution - **cli/plugins.ts**: Import and register cursor in agentPlugins map for getAgent/getAgentByName - **cli/detect-agent.ts**: Add cursor to AGENT_PLUGINS array for detectAvailableAgents() - **web/services.ts**: Import and register cursor plugin for dashboard SessionManager/LifecycleManager - **web/package.json**: Add @composio/ao-plugin-agent-cursor dependency ### Activity Detection Fix (Medium Severity) - **cursor/index.ts**: Remove overly broad blocked detection patterns (error:/failed:) - Compiler errors, test failures, and linter output are normal tool output - Terminal-based detection can't distinguish between actionable agent errors and normal output - Follow Aider/OpenCode pattern: only Claude Code detects blocked (has native JSONL) - Added comment explaining why blocked detection is removed - **cursor/index.test.ts**: Remove blocked detection test cases ## Why These Changes Are Needed Before these fixes: - `defaults.agent: cursor` in config would throw "Unknown agent plugin: cursor" - `ao spawn --agent cursor` would fail - Dashboard couldn't resolve cursor agent (SessionManager/LifecycleManager failures) - `detectAvailableAgents()` never discovered Cursor - False "blocked" states when agent encountered normal compiler errors After these fixes: - Cursor agent fully discoverable and usable via config and CLI - Dashboard can spawn and manage Cursor sessions - Activity detection matches other terminal-based agents (Aider, OpenCode) - No false positives from normal tool output ## Testing - ✅ cursor plugin tests: 51/51 passing (reduced from 52 due to removed blocked tests) - ✅ core typecheck: clean - ✅ web typecheck: clean - ✅ CLI can import cursor plugin without errors Addresses: ComposioHQ/agent-orchestrator#1076 Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com> |
||
|---|---|---|
| .. | ||
| src | ||
| package.json | ||
| tsconfig.json | ||