From e90c7f7ff20a4f06b361eec2deeba52a1aa221ea Mon Sep 17 00:00:00 2001
From: Prateek <karnalprateek@gmail.com>
Date: Sat, 7 Mar 2026 20:31:35 +0530
Subject: [PATCH] fix: disable codex startup update check via config override

---
 packages/plugins/agent-codex/src/index.test.ts | 16 +++++++++++-----
 packages/plugins/agent-codex/src/index.ts      |  7 +++++++
 2 files changed, 18 insertions(+), 5 deletions(-)

diff --git a/packages/plugins/agent-codex/src/index.test.ts b/packages/plugins/agent-codex/src/index.test.ts
index eb611a3c7..5e9e2c05f 100644
--- a/packages/plugins/agent-codex/src/index.test.ts
+++ b/packages/plugins/agent-codex/src/index.test.ts
@@ -210,7 +210,7 @@ describe("getLaunchCommand", () => {
   const agent = create();
 
   it("generates base command", () => {
-    expect(agent.getLaunchCommand(makeLaunchConfig())).toBe("'codex'");
+    expect(agent.getLaunchCommand(makeLaunchConfig())).toBe("'codex' -c check_for_update_on_startup=false");
   });
 
   it("includes --dangerously-bypass-approvals-and-sandbox when permissions=skip", () => {
@@ -255,7 +255,7 @@ describe("getLaunchCommand", () => {
     const cmd = agent.getLaunchCommand(
       makeLaunchConfig({ permissions: "skip", model: "o3", prompt: "Go" }),
     );
-    expect(cmd).toBe("'codex' --dangerously-bypass-approvals-and-sandbox --model 'o3' -c model_reasoning_effort=high -- 'Go'");
+    expect(cmd).toBe("'codex' -c check_for_update_on_startup=false --dangerously-bypass-approvals-and-sandbox --model 'o3' -c model_reasoning_effort=high -- 'Go'");
   });
 
   it("escapes single quotes in prompt (POSIX shell escaping)", () => {
@@ -294,10 +294,15 @@ describe("getLaunchCommand", () => {
     expect(cmd).not.toContain("--dangerously-bypass-approvals-and-sandbox");
     expect(cmd).not.toContain("--ask-for-approval");
     expect(cmd).not.toContain("--model");
-    expect(cmd).not.toContain("-c");
+    expect(cmd).toContain("-c check_for_update_on_startup=false");
     expect(cmd).not.toContain("model_reasoning_effort");
   });
 
+  it("always includes -c check_for_update_on_startup=false", () => {
+    const cmd = agent.getLaunchCommand(makeLaunchConfig({ model: "gpt-4o", prompt: "Fix it" }));
+    expect(cmd).toContain("-c check_for_update_on_startup=false");
+  });
+
   // -- Reasoning effort tests --
   describe("reasoning effort", () => {
     it("adds model_reasoning_effort=high for o3 model", () => {
@@ -967,6 +972,7 @@ describe("getRestoreCommand", () => {
 
     expect(cmd).not.toBeNull();
     expect(cmd).toContain("'codex' resume");
+    expect(cmd).toContain("-c check_for_update_on_startup=false");
     expect(cmd).toContain("thread-abc-123");
   });
 
@@ -1218,13 +1224,13 @@ describe("postLaunchSetup", () => {
     mockReadFile.mockRejectedValue(new Error("ENOENT"));
 
     // Before postLaunchSetup, binary is "codex"
-    expect(agent.getLaunchCommand(makeLaunchConfig())).toBe("'codex'");
+    expect(agent.getLaunchCommand(makeLaunchConfig())).toBe("'codex' -c check_for_update_on_startup=false");
 
     // After postLaunchSetup resolves the binary
     await agent.postLaunchSetup!(makeSession({ workspacePath: "/workspace/test" }));
 
     // Now getLaunchCommand should use the resolved binary
-    expect(agent.getLaunchCommand(makeLaunchConfig())).toBe("'/opt/bin/codex'");
+    expect(agent.getLaunchCommand(makeLaunchConfig())).toBe("'/opt/bin/codex' -c check_for_update_on_startup=false");
   });
 });
 
diff --git a/packages/plugins/agent-codex/src/index.ts b/packages/plugins/agent-codex/src/index.ts
index ec68115c7..baed566f1 100644
--- a/packages/plugins/agent-codex/src/index.ts
+++ b/packages/plugins/agent-codex/src/index.ts
@@ -538,6 +538,11 @@ function appendModelFlags(parts: string[], model: string | undefined): void {
   }
 }
 
+/** Disable Codex startup update checks/prompts in non-interactive sessions */
+function appendNoUpdateCheckFlag(parts: string[]): void {
+  parts.push("-c", "check_for_update_on_startup=false");
+}
+
 /** TTL for session file path cache (ms). Prevents redundant filesystem scans
  *  when getActivityState and getSessionInfo are called in the same refresh cycle. */
 const SESSION_FILE_CACHE_TTL_MS = 30_000;
@@ -570,6 +575,7 @@ function createCodexAgent(): Agent {
     getLaunchCommand(config: AgentLaunchConfig): string {
       const binary = resolvedBinary ?? "codex";
       const parts: string[] = [shellEscape(binary)];
+      appendNoUpdateCheckFlag(parts);
 
       appendApprovalFlags(parts, config.permissions as string | undefined);
       appendModelFlags(parts, config.model);
@@ -761,6 +767,7 @@ function createCodexAgent(): Agent {
       // Flags are placed before the positional threadId for CLI parser compatibility.
       const binary = resolvedBinary ?? "codex";
       const parts: string[] = [shellEscape(binary), "resume"];
+      appendNoUpdateCheckFlag(parts);
 
       appendApprovalFlags(parts, project.agentConfig?.permissions as string | undefined);
       const effectiveModel = (project.agentConfig?.model ?? data.model) as string | undefined;