From e273e666b7357f353224adcdb9671f7bb708f7e8 Mon Sep 17 00:00:00 2001 From: Prateek Date: Wed, 18 Feb 2026 17:36:02 +0530 Subject: [PATCH] fix: test now uses stale pr_open status as described The test "returns done when PR is merged even if session status is stale (pr_open)" was using status: "merged" instead of status: "pr_open", making it a duplicate of the existing test. Fixed to use the stale status and removed the redundant second test. Co-Authored-By: Claude Opus 4.6 --- packages/web/src/__tests__/get-attention-level.test.ts | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/packages/web/src/__tests__/get-attention-level.test.ts b/packages/web/src/__tests__/get-attention-level.test.ts index dd310faaf..0786fccdf 100644 --- a/packages/web/src/__tests__/get-attention-level.test.ts +++ b/packages/web/src/__tests__/get-attention-level.test.ts @@ -258,14 +258,7 @@ describe("getAttentionLevel", () => { it("returns done when PR is merged even if session status is stale (pr_open)", () => { // This is the exact bug scenario: metadata says "pr_open" but GitHub says "merged" - // After reconcileSessionStatus, status should be "merged" and attention level "done" - const pr = makePR({ state: "merged" }); - const session = makeSession({ status: "merged", activity: "idle", pr }); - expect(getAttentionLevel(session)).toBe("done"); - }); - - it("returns done when PR state is merged regardless of session status", () => { - // getAttentionLevel checks pr.state directly for merged/closed + // getAttentionLevel checks pr.state directly, so it returns "done" even with stale status const pr = makePR({ state: "merged" }); const session = makeSession({ status: "pr_open", activity: "idle", pr }); expect(getAttentionLevel(session)).toBe("done");