bkinnightskytw
/
agent-orchestrator
mirror of https://github.com/ComposioHQ/agent-orchestrator.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

fix: fetch automated PR comments via explicit GET pagination (#447)

This commit is contained in:
Harsh Batheja 2026-03-12 21:00:52 +05:30 committed by GitHub
parent 3d518aed2f
commit dc85cdbe01
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 75 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

39
packages/plugins/scm-github/src/index.ts
View File

@ -860,14 +860,7 @@ function createGitHubSCM(): SCM {
async getAutomatedComments(pr: PRInfo): Promise<AutomatedComment[]> {
try {
// Fetch all review comments with max page size (100 is GitHub's limit)
const raw = await gh([
"api",
"-F",
"per_page=100",
`repos/${repoFlag(pr)}/pulls/${pr.number}/comments`,
]);
const perPage = 100;
const comments: Array<{
id: number;
user: { login: string };
@ -877,7 +870,35 @@ function createGitHubSCM(): SCM {
original_line: number | null;
created_at: string;
html_url: string;
}> = JSON.parse(raw);
}> = [];
for (let page = 1; ; page++) {
const raw = await gh([
"api",
"--method",
"GET",
`repos/${repoFlag(pr)}/pulls/${pr.number}/comments?per_page=${perPage}&page=${page}`,
]);
const pageComments: Array<{
id: number;
user: { login: string };
body: string;
path: string;
line: number | null;
original_line: number | null;
created_at: string;
html_url: string;
}> = JSON.parse(raw);
if (pageComments.length === 0) {
break;
}
comments.push(...pageComments);
if (pageComments.length < perPage) {
break;
}
}
return comments
.filter((c) => BOT_AUTHORS.has(c.user?.login ?? ""))

45
packages/plugins/scm-github/test/index.test.ts
View File

@ -908,6 +908,51 @@ describe("scm-github plugin", () => {
// ---- getAutomatedComments ----------------------------------------------
describe("getAutomatedComments", () => {
it("uses explicit GET query for pulls comments and paginates", async () => {
const page1 = Array.from({ length: 100 }, (_, i) => ({
id: i + 1,
user: { login: "cursor[bot]" },
body: "Potential issue detected",
path: "a.ts",
line: i + 1,
original_line: null,
created_at: "2025-01-01T00:00:00Z",
html_url: `u${i + 1}`,
}));
const page2 = [
{
id: 101,
user: { login: "cursor[bot]" },
body: "Warning: check this",
path: "b.ts",
line: 7,
original_line: null,
created_at: "2025-01-01T00:00:00Z",
html_url: "u101",
},
];
mockGh(page1);
mockGh(page2);
const comments = await scm.getAutomatedComments(pr);
expect(comments).toHaveLength(101);
expect(ghMock).toHaveBeenNthCalledWith(
1,
"gh",
["api", "--method", "GET", "repos/acme/repo/pulls/42/comments?per_page=100&page=1"],
expect.any(Object),
);
expect(ghMock).toHaveBeenNthCalledWith(
2,
"gh",
["api", "--method", "GET", "repos/acme/repo/pulls/42/comments?per_page=100&page=2"],
expect.any(Object),
);
});
it("returns bot comments filtered from all PR comments", async () => {
mockGh([
{