From ae8cf46d6417efcf5526a02b1263fbc46919fefc Mon Sep 17 00:00:00 2001 From: Prateek Date: Sun, 15 Feb 2026 03:28:26 +0530 Subject: [PATCH] fix: update plugin-integration tests for getCIChecks field name changes MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The getCIChecks fix changed field names from `conclusion`/`detailsUrl` to `state`/`link`. Updated test mocks to match: - Changed `conclusion: "SUCCESS"` → `state: "SUCCESS"` - Changed `conclusion: "FAILURE"` → `state: "FAILURE"` - Changed `detailsUrl` → `link` Tests now pass with correct field names. Co-Authored-By: Claude Sonnet 4.5 --- packages/core/src/__tests__/plugin-integration.test.ts | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/packages/core/src/__tests__/plugin-integration.test.ts b/packages/core/src/__tests__/plugin-integration.test.ts index 3c063175d..040ee8964 100644 --- a/packages/core/src/__tests__/plugin-integration.test.ts +++ b/packages/core/src/__tests__/plugin-integration.test.ts @@ -436,9 +436,9 @@ describe("plugin integration", () => { // gh calls for determineStatus: // 1. getPRState → open mockGh({ state: "OPEN" }); - // 2. getCISummary → failing (pr checks returns array of checks) + // 2. getCISummary → failing (pr checks returns array of checks with correct field names) mockGh([ - { name: "lint", state: "COMPLETED", conclusion: "FAILURE", detailsUrl: "", startedAt: "", completedAt: "" }, + { name: "lint", state: "FAILURE", link: "", startedAt: "", completedAt: "" }, ]); await lm.check("app-1"); @@ -492,9 +492,9 @@ describe("plugin integration", () => { // 1. getPRState → open mockGh({ state: "OPEN" }); - // 2. getCISummary → passing + // 2. getCISummary → passing (using correct field names: state and link) mockGh([ - { name: "lint", state: "COMPLETED", conclusion: "SUCCESS", detailsUrl: "", startedAt: "", completedAt: "" }, + { name: "lint", state: "SUCCESS", link: "", startedAt: "", completedAt: "" }, ]); // 3. getReviewDecision (gh pr view with reviewDecision) mockGh({ reviewDecision: "CHANGES_REQUESTED" });