bkinnightskytw
/
agent-orchestrator
mirror of https://github.com/ComposioHQ/agent-orchestrator.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

fix: prevent project workspace deletion and agent config workspace leak 

- kill() skips workspace.destroy when worktree matches project.path
- spawn() wraps getLaunchCommand/getEnvironment in workspace cleanup guard

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This commit is contained in:
Prateek 2026-02-13 18:55:07 +05:30
parent ad0b45006c
commit 88ea7d1491
1 changed files with 10 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
packages/core/src/session-manager.ts
View File

@ -200,7 +200,7 @@ export function createSessionManager(deps: SessionManagerDeps): SessionManager {
}
}
// Get agent launch config
// Get agent launch config and create runtime — clean up workspace on failure
const agentLaunchConfig = {
sessionId,
projectConfig: project,
@ -210,12 +210,11 @@ export function createSessionManager(deps: SessionManagerDeps): SessionManager {
model: project.agentConfig?.model,
};
const launchCommand = plugins.agent.getLaunchCommand(agentLaunchConfig);
const environment = plugins.agent.getEnvironment(agentLaunchConfig);
// Create runtime session — clean up workspace on failure
let handle: RuntimeHandle;
try {
const launchCommand = plugins.agent.getLaunchCommand(agentLaunchConfig);
const environment = plugins.agent.getEnvironment(agentLaunchConfig);
handle = await plugins.runtime.create({
sessionId,
workspacePath,
@ -226,7 +225,7 @@ export function createSessionManager(deps: SessionManagerDeps): SessionManager {
},
});
} catch (err) {
// Clean up workspace if runtime creation failed
// Clean up workspace if agent config or runtime creation failed
if (plugins.workspace && workspacePath !== project.path) {
try {
await plugins.workspace.destroy(workspacePath);
@ -371,14 +370,16 @@ export function createSessionManager(deps: SessionManagerDeps): SessionManager {
}
}
// Destroy workspace (attempt even without project config using default workspace)
if (raw["worktree"]) {
// Destroy workspace — skip if worktree is the project path (no isolation was used)
const worktree = raw["worktree"];
const isProjectPath = project && worktree === project.path;
if (worktree && !isProjectPath) {
const workspacePlugin = project
? resolvePlugins(project).workspace
: registry.get<Workspace>("workspace", config.defaults.workspace);
if (workspacePlugin) {
try {
await workspacePlugin.destroy(raw["worktree"]);
await workspacePlugin.destroy(worktree);
} catch {
// Workspace might already be gone
}