From 7f566a331b8f1fd32bdb1ab84a7f019c577cce26 Mon Sep 17 00:00:00 2001 From: whoisasx Date: Wed, 20 May 2026 21:34:46 +0530 Subject: [PATCH] fix: address notifier onboarding review (#1958) --- packages/cli/src/commands/start.ts | 2 +- .../src/notifier-desktop.integration.test.ts | 4 +++- packages/plugins/notifier-desktop/src/index.ts | 4 ++-- 3 files changed, 6 insertions(+), 4 deletions(-) diff --git a/packages/cli/src/commands/start.ts b/packages/cli/src/commands/start.ts index c675b5654..e56390f93 100644 --- a/packages/cli/src/commands/start.ts +++ b/packages/cli/src/commands/start.ts @@ -176,7 +176,7 @@ async function ensureDefaultStartupNotifiers( dashboardUrl, desktopMode, }); - return changed ? loadConfig(config.configPath) : config; + return changed ? loadConfig(targetConfigPath) : config; } function readProjectBehaviorConfig(projectPath: string): LocalProjectConfig { diff --git a/packages/integration-tests/src/notifier-desktop.integration.test.ts b/packages/integration-tests/src/notifier-desktop.integration.test.ts index 52fe1b075..cd9463f38 100644 --- a/packages/integration-tests/src/notifier-desktop.integration.test.ts +++ b/packages/integration-tests/src/notifier-desktop.integration.test.ts @@ -11,7 +11,9 @@ import { makeEvent } from "./helpers/event-factory.js"; vi.mock("node:child_process", () => ({ execFile: vi.fn(), execFileSync: vi.fn(() => { - throw new Error("not found"); + const error = new Error("not found") as NodeJS.ErrnoException; + error.code = "ENOENT"; + throw error; }), })); diff --git a/packages/plugins/notifier-desktop/src/index.ts b/packages/plugins/notifier-desktop/src/index.ts index 55268b041..47bee1d25 100644 --- a/packages/plugins/notifier-desktop/src/index.ts +++ b/packages/plugins/notifier-desktop/src/index.ts @@ -383,8 +383,8 @@ function detectTerminalNotifier(): boolean { try { execFileSync("terminal-notifier", ["--version"], { stdio: "ignore", windowsHide: true }); return true; - } catch { - return false; + } catch (error) { + return (error as NodeJS.ErrnoException).code !== "ENOENT"; } }