From 105f26253eb6cb51c8aa657f22cb883ddf0e1f2d Mon Sep 17 00:00:00 2001
From: Prateek <karnalprateek@gmail.com>
Date: Tue, 17 Feb 2026 11:30:13 +0530
Subject: [PATCH] fix: strengthen integration test to catch WebSocket bug
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

**Problem:**
- Test only warned about missing WebSocket servers (didn't fail)
- Wouldn't have caught the bug your friend encountered

**Solution:**
1. Make WebSocket server check mandatory (fail if not responding)
2. Add retry logic (wait up to 10s for servers to start)
3. Add end-to-end test: verify orchestrator terminal page loads

**Now catches:**
✅ Config discovery bug (API endpoint fails if config not loaded)
✅ WebSocket server bug (test fails if servers not started)
✅ Terminal page bug (test fails if session page doesn't load)

All bugs from your friend's experience are now covered!

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
---
 tests/integration/onboarding-test.sh | 50 +++++++++++++++++++++++-----
 1 file changed, 42 insertions(+), 8 deletions(-)

diff --git a/tests/integration/onboarding-test.sh b/tests/integration/onboarding-test.sh
index 4e40bd962..b8dd76ac9 100755
--- a/tests/integration/onboarding-test.sh
+++ b/tests/integration/onboarding-test.sh
@@ -129,16 +129,50 @@ end_step "Step 7: Dashboard API responding"
 # Step 8: Verify WebSocket terminal servers
 start_step "Step 8: Verify WebSocket servers"
 
-# Check if direct terminal WebSocket server is running
-if ! curl -sf http://localhost:3003/health > /dev/null 2>&1; then
-    echo -e "${YELLOW}  Warning: Direct terminal WebSocket server not responding${NC}"
-    echo -e "${YELLOW}  (This is expected if pnpm dev is not running all services)${NC}"
+# Check if direct terminal WebSocket server is running (required for terminal feature)
+echo "  Checking WebSocket server on port 3003..."
+max_retries=10
+for i in $(seq 1 $max_retries); do
+    if curl -sf http://localhost:3003/health > /dev/null 2>&1; then
+        echo "  ✓ WebSocket server responding"
+        break
+    fi
+    if [ $i -eq $max_retries ]; then
+        fail_step "Step 8: WebSocket terminal server not responding (bug: ao start didn't launch all services)"
+    fi
+    sleep 1
+done
+
+end_step "Step 8: WebSocket servers verified"
+
+# Step 9: Verify orchestrator terminal page (end-to-end test)
+start_step "Step 9: Verify orchestrator terminal feature"
+
+# Create orchestrator session first (so we have something to test)
+echo "  Creating test orchestrator session..."
+tmux new-session -d -s test-project-orchestrator || true
+
+# Write minimal metadata
+mkdir -p /tmp/ao-test-data
+cat > /tmp/ao-test-data/test-project-orchestrator << 'EOF'
+worktree=/tmp/ao-test-project
+branch=main
+status=working
+project=test-project
+EOF
+
+# Test that the session detail page loads (where terminal would be)
+if ! curl -sf http://localhost:4000/sessions/test-project-orchestrator > /dev/null; then
+    fail_step "Step 9: Orchestrator session page failed to load"
 fi
 
-end_step "Step 8: WebSocket server check completed"
+# Cleanup test session
+tmux kill-session -t test-project-orchestrator 2>/dev/null || true
 
-# Step 9: Cleanup
-start_step "Step 9: Cleanup"
+end_step "Step 9: Orchestrator terminal page accessible"
+
+# Step 10: Cleanup
+start_step "Step 10: Cleanup"
 kill $DASHBOARD_PID 2>/dev/null || true
 # Wait for process to exit
 sleep 2
@@ -149,7 +183,7 @@ kill -9 $DASHBOARD_PID 2>/dev/null || true
 pkill -f "node.*next.*dev" || true
 pkill -f "tsx.*terminal" || true
 
-end_step "Step 9: Cleanup completed"
+end_step "Step 10: Cleanup completed"
 
 # Calculate total time
 end_time=$(date +%s)