bkinnightskytw
/
agent-orchestrator
mirror of https://github.com/ComposioHQ/agent-orchestrator.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

fix(cli): clear SIGKILL fallback timer when child exits cleanly 

If the child exits before the 5-second escalation window, the fallback
setTimeout would still fire and call process.exit(1). Track the timer
in the outer scope so the child.once("exit") handler can cancel it.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This commit is contained in:
Priyanshu Choudhary 2026-04-09 00:10:57 +05:30
parent 335609e443
commit 0db7bb18ef
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
packages/cli/src/lib/shell.ts
View File

@ -64,12 +64,14 @@ export async function getTmuxSessions(): Promise<string[]> {
* handlers registered. Cleans up automatically when the child exits normally.
*/
export function forwardSignalsToChild(pid: number, child: ChildProcess): void {
let fallback: ReturnType<typeof setTimeout> | undefined;
const forward = (): void => {
process.off("SIGINT", forward);
process.off("SIGTERM", forward);
void killProcessTree(pid, "SIGTERM");
// If the child ignores SIGTERM, force-kill after 5 s so the parent exits.
const fallback = setTimeout(() => {
fallback = setTimeout(() => {
void killProcessTree(pid, "SIGKILL").finally(() => process.exit(1));
}, 5000);
fallback.unref();
@ -79,6 +81,7 @@ export function forwardSignalsToChild(pid: number, child: ChildProcess): void {
child.once("exit", () => {
process.off("SIGINT", forward);
process.off("SIGTERM", forward);
if (fallback !== undefined) clearTimeout(fallback);
});
}