From 0c535c98d7d74225f2a637a3384fe16c401c9347 Mon Sep 17 00:00:00 2001 From: prateek Date: Fri, 13 Feb 2026 18:41:58 +0530 Subject: [PATCH] fix: CI handles Next.js build separately, fix web tsconfig (#14) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit * fix: CI workflow handles Next.js build separately, fix web tsconfig rootDir - Remove rootDir from web tsconfig (conflicts with Next.js generated .next/types) - Include .next/types/**/*.ts in web tsconfig - CI: build non-web packages first, web build allowed to soft-fail - CI: typecheck excludes web (typechecked by next build) - CI: test excludes web build dependency Co-Authored-By: Claude Opus 4.6 * fix: remove || true from web build — bugbot caught it, web errors should fail CI Co-Authored-By: Claude Opus 4.6 * fix: override rootDir in web tsconfig to "." for Next.js compat Next.js generates .next/types/ files that must be under rootDir. Base tsconfig sets rootDir to "src", web needs "." to include both src/ and .next/types/. Co-Authored-By: Claude Opus 4.6 --------- Co-authored-by: Claude Opus 4.6 --- .github/workflows/ci.yml | 10 +++++++--- packages/web/tsconfig.json | 4 ++-- 2 files changed, 9 insertions(+), 5 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 1d1b46a4f..7932dccad 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -35,8 +35,12 @@ jobs: node-version: 20 cache: pnpm - run: pnpm install --frozen-lockfile - - run: pnpm build - - run: pnpm typecheck + # Build all non-web packages + - run: pnpm -r --filter '!@agent-orchestrator/web' build + # Typecheck all non-web packages + - run: pnpm -r --filter '!@agent-orchestrator/web' typecheck + # Build web (Next.js build includes its own typecheck) + - run: pnpm --filter @agent-orchestrator/web build test: name: Test @@ -49,5 +53,5 @@ jobs: node-version: 20 cache: pnpm - run: pnpm install --frozen-lockfile - - run: pnpm build + - run: pnpm -r --filter '!@agent-orchestrator/web' build - run: pnpm test diff --git a/packages/web/tsconfig.json b/packages/web/tsconfig.json index 4df6fe12c..8d8f525eb 100644 --- a/packages/web/tsconfig.json +++ b/packages/web/tsconfig.json @@ -2,7 +2,7 @@ "extends": "../../tsconfig.base.json", "compilerOptions": { "outDir": "dist", - "rootDir": "src", + "rootDir": ".", "jsx": "preserve", "module": "ESNext", "moduleResolution": "Bundler", @@ -11,6 +11,6 @@ "@/*": ["./src/*"] } }, - "include": ["src", "next-env.d.ts"], + "include": ["src", "next-env.d.ts", ".next/types/**/*.ts"], "exclude": ["node_modules"] }