The use of `else` or `elif` becomes redundant and can be dropped if the last statement under the leading `if` / `elif` block is a `return` statement.
In the case of an `elif` after `return`, it can be written as a separate `if` block.
For `else` blocks after `return`, the statements can be shifted out of `else`. Please refer to the examples below for reference.
Refactoring the code this way can improve code-readability and make it easier to maintain.
Co-authored-by: deepsource-autofix[bot] <62050782+deepsource-autofix[bot]@users.noreply.github.com>
There shouldn't be any blank lines after the function docstring.
Remove the blank lines to fix this issue.
Co-authored-by: deepsource-autofix[bot] <62050782+deepsource-autofix[bot]@users.noreply.github.com>
* Add plugin mixin class for supporting exchange rates
* Split some mixin classes out into their own files
- mixins.py is becoming quite bloated!
* Add some new settings for controlling currency updates
* Adds basic plugin implementation
* Refactor existing implementation
- Builtin plugin uses frankfurter.app API
- Better error / edge case handlign
* Add sample plugin for currency exchange
* Allow user to select which plugin to use for plugin updates
* Observe user-configured setting for how often exchange rates are updated
* Updates for some of the sample plugins
* Fix plugin slug
* Add doc page
* Document simple example
* Improve sample
* Add blank page for currency settings info
* More info in "config" page
* Update docs again
* Updated unit tests
* Fill out default settings values when InvenTree runs
* Add log messages
* Significant improvement in default settings speed
- Use bulk create
- Be efficient
- Dont' be inefficient
* More strict checks
* Refactor default values implementation
- Don't run at startup
- Run on list API
- Implement generic @classmethod
* Cleanup plugin settings page
- Template adjustments
* Activate plugin directly via API
* Update plugin activate endpoint
- Allow plugin to be deactivated also
- Default value = True if not provided
* Update front-end / js
- Allow same JS method to either enable or disable a plugin
* Hide info for plugins which are not active
* remove duplicated column
* Tweak serializer docstring
* Fix typo
* Add extra data to plugin serializer
- is_builtin
- is_sample
* Some backend cleanup
- Don't stringify null values
- Don't replace None with "Unavailable"
* front-end table for rendering plugins
* Change default sorting
- Show active plugins first
* Fix button callback
* Remove old template
* JS linting
* More linting
* collect mixins dynamically
* remove unfinsihed option to reorder mixins
* clean up settings
* fix text
* fix mixin lookup
* stupid error
* fix assertations
* use regustered function instead of private dict
* switch to dict for reg
* fix test
* makke sure mixins also works with class
* cleanup
* fix reqs
* fix test assertations
* Allow loading of "builtin" plugins, even if "plugins" are not explicitly loaded
* Updates for 'admin' buttons:
- Make them work like proper links
- Hidden if 'hide_admin_link' customization option is set
- Check for user staff status
* Cleanup rendering of "plugins" display
* Consolidate InvenTree barcode plugins into single plugin class
* Hide "install plugin" button if plugins are not enabled
* Add info message is external plugins are not enabled
* Fixes for loading plugins
- Always load 'builtin' plugins
- Refactor calls to "is_active" at various points in codebase
* Various tweaks
- Improve builtin plugin descriptions
- Spelling fixes
* Adjust plugin detail for builtin plugins
* Simplify barcode plugin class
* Simplify template rendering
* Bug fix for inventree barcode plugin
* Revert "Simplify template rendering"
This reverts commit 3a6755a659.
* Re-re-improve template rendering
- Required as the template has been refactored for both "active" and "inactive" plugins
* Fixing unit tests for barcode plugin
* Ensure that barcode scan actions do not take a "long time":
- Add a default timeout of 0.1s to any POST or GET request in the testing framework
- Can be overridden by calling method if desired
* Display plugin "builtin" status in admin panel
* Fix unit tests for plugin API
* Further unit testing fixes
* Version number tweaks
* Further tweaks for unit testing
* Allow longer timeout for report printing via API
* Increase default timeout for API tests
- Sometimes CPU spike can cause the test to fail :|
* label printing can take a bit longer
* Remove timeout requirement from API tester
- Too variable to be reliable for CI
* out-of-scope: add function to check if a package is editable
* out-of-scope: move to included meta toolset for metadata discovery
* out-of-scope: make lookup safe for editable installs
* refactor entrypoint into helpers
* Add lookup by metadata
This is geared towards plugins packaged in pkgs that differ in name from their top module
* Make module lookup predictable in changing pkg-envs
* remove no coverage from plugin packages
* ignore coverage for production loadin
* refactor plugin collection - move assigment out
* do not cover fs errors
* test custom dir loading
* test module meta fetcher
* add a bit more safety
* do not cover sanity checkers
* add folder loading test
* ignore again for cleaner diffs for now
* ignore safety catch
* rename test
* Add test for package installs
* fix docstring name
* depreciate test for now
* Fix for out of BASE_DIR paths
* ignore catch
* remove unneeded complexity
* add testing for outside folders
* more docstrings and simpler methods
* make call simpler
* refactor import
* Add registry with all plugins
* use full registry and make simpler request
* switch path properties to methods
* Add typing to plugin
* Add a checker fnc for is_sample
* Add sample check to admin page
* Make file check a cls
* more cls methods
* Add setting for signature cheks
Fixes#3520
* make property statements simpler
* use same key in all dicts
* Use module name instead of NAME
Fixes#3534
* fix naming
* fix name
* add version checking
Fixes#3478
* fix formatting and typing
* also save reference to full array
* do not cover as we turn on all plugins
* add test for check_version
* Add version e2e test
* make test save
* refactor out assignment
* safe a db reference first
* docstring
* condense code a bit
* rename
* append logging
* rename
* also safe db reference to new object
* docstrings, refactors, typing
* fix key lookup
* refactor entrypoint into helpers
* Add lookup by metadata
This is geared towards plugins packaged in pkgs that differ in name from their top module
* Make module lookup predictable in changing pkg-envs
* Load custom plugin directories
* Allow plugins to be loaded from an external directory
* Handle exception when path is not relative to base path
* Fix typo
* Use pathlib
* Move plugin directory code into registry.py
- Allows us to reload plugins without having to reload the server itself
Co-authored-by: Matthias Mair <code@mjmair.com>
* Add pre-commit to the stack
* exclude static
* Add locales to excludes
* fix style errors
* rename pipeline steps
* also wait on precommit
* make template matching simpler
* Use the same code for python setup everywhere
* use step and cache for python setup
* move regular settings up into general envs
* just use full update
* Use invoke instead of static references
* make setup actions more similar
* use python3
* refactor names to be similar
* fix runner version
* fix references
* remove incidential change
* use matrix for os
* Github can't do this right now
* ignore docstyle errors
* Add seperate docstring test
* update flake call
* do not fail on docstring
* refactor setup into workflow
* update reference
* switch to action
* resturcture
* add bash statements
* remove os from cache
* update input checks
* make code cleaner
* fix boolean
* no relative paths
* install wheel by python
* switch to install
* revert back to simple wheel
* refactor import export tests
* move setup keys back to not disturbe tests
* remove docstyle till that is fixed
* update references
* continue on error
* add docstring test
* use relativ action references
* Change step / job docstrings
* update to merge
* reformat comments 1
* fix docstrings 2
* fix docstrings 3
* fix docstrings 4
* fix docstrings 5
* fix docstrings 6
* fix docstrings 7
* fix docstrings 8
* fix docstirns 9
* fix docstrings 10
* docstring adjustments
* update the remaining docstrings
* small docstring changes
* fix function name
* update support files for docstrings
* Add missing args to docstrings
* Remove outdated function
* Add docstrings for the 'build' app
* Make API code cleaner
* add more docstrings for plugin app
* Remove dead code for plugin settings
No idea what that was even intended for
* ignore __init__ files for docstrings
* More docstrings
* Update docstrings for the 'part' directory
* Fixes for related_part functionality
* Fix removed stuff from merge 99676ee
* make more consistent
* Show statistics for docstrings
* add more docstrings
* move specific register statements to make them clearer to understant
* More docstrings for common
* and more docstrings
* and more
* simpler call
* docstrings for notifications
* docstrings for common/tests
* Add docs for common/models
* Revert "move specific register statements to make them clearer to understant"
This reverts commit ca96654622.
* use typing here
* Revert "Make API code cleaner"
This reverts commit 24fb68bd3e.
* docstring updates for the 'users' app
* Add generic Meta info to simple Meta classes
* remove unneeded unique_together statements
* More simple metas
* Remove unnecessary format specifier
* Remove extra json format specifiers
* Add docstrings for the 'plugin' app
* Docstrings for the 'label' app
* Add missing docstrings for the 'report' app
* Fix build test regression
* Fix top-level files
* docstrings for InvenTree/InvenTree
* reduce unneeded code
* add docstrings
* and more docstrings
* more docstrings
* more docstrings for stock
* more docstrings
* docstrings for order/views
* Docstrings for various files in the 'order' app
* Docstrings for order/test_api.py
* Docstrings for order/serializers.py
* Docstrings for order/admin.py
* More docstrings for the order app
* Add docstrings for the 'company' app
* Add unit tests for rebuilding the reference fields
* Prune out some more dead code
* remove more dead code
Co-authored-by: Oliver Walters <oliver.henry.walters@gmail.com>
Oliver
Matthias Mair
Lukas
Matthias