Fix for STOCK_COUNT event (#12281)
* Fix for STOCK_COUNT event - Prevent double emission of event type string * adjust unit test
This commit is contained in:
parent
6111aace1f
commit
fb280d80e7
|
|
@ -2663,7 +2663,7 @@ class StockItem(
|
|||
return True
|
||||
|
||||
@transaction.atomic
|
||||
def stocktake(self, count, user, **kwargs):
|
||||
def stocktake(self, count, user, **kwargs) -> None:
|
||||
"""Perform item stocktake.
|
||||
|
||||
Arguments:
|
||||
|
|
@ -2678,7 +2678,7 @@ class StockItem(
|
|||
try:
|
||||
count = Decimal(count)
|
||||
except InvalidOperation:
|
||||
return False
|
||||
return
|
||||
|
||||
if count < 0:
|
||||
return False
|
||||
|
|
@ -2729,13 +2729,10 @@ class StockItem(
|
|||
|
||||
trigger_event(
|
||||
StockEvents.ITEM_COUNTED,
|
||||
'stockitem.counted',
|
||||
id=self.id,
|
||||
quantity=1 if self.serialized else float(self.quantity),
|
||||
)
|
||||
|
||||
return True
|
||||
|
||||
@transaction.atomic
|
||||
def add_stock(self, quantity, user, **kwargs):
|
||||
"""Add a specified quantity of stock to this item.
|
||||
|
|
|
|||
|
|
@ -378,10 +378,8 @@ class StockTest(StockTestBase):
|
|||
self.assertEqual(it.status, StockStatus.OK.value)
|
||||
|
||||
# Next, perform a valid stocktake
|
||||
self.assertTrue(
|
||||
it.stocktake(
|
||||
100, None, notes='test stocktake', status=StockStatus.DAMAGED.value
|
||||
)
|
||||
it.stocktake(
|
||||
100, None, notes='test stocktake', status=StockStatus.DAMAGED.value
|
||||
)
|
||||
|
||||
it.refresh_from_db()
|
||||
|
|
|
|||
Loading…
Reference in New Issue