Lock notes on orders if they are completed (#11880) (#11882)

* Lock notes on orders if they are completed
Fixes #11879

* also check setting

* use statuscode object

* remove build lock

(cherry picked from commit 610e275ca0)

Co-authored-by: Matthias Mair <code@mjmair.com>
This commit is contained in:
github-actions[bot] 2026-05-07 08:42:34 +10:00 committed by GitHub
parent 599bf16c32
commit 457e8b4325
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
3 changed files with 15 additions and 3 deletions

View File

@ -209,7 +209,7 @@ export default function NotesEditor({
const sibling =
mdeInstance?.codemirror.getWrapperElement()?.nextSibling;
if (sibling != null) {
if (sibling != null && editable != false) {
EasyMDE.togglePreview(mdeInstance);
}
}

View File

@ -410,7 +410,13 @@ export default function PurchaseOrderDetail() {
NotesPanel({
model_type: ModelType.purchaseorder,
model_id: order.pk,
has_note: !!order.notes
has_note: !!order.notes,
// TODO @matmair - change API to include a "locked" attribute that we can check here
editable:
order.status == poStatus.COMPLETE &&
!globalSettings.isSet('PURCHASEORDER_EDIT_COMPLETED_ORDERS')
? false
: undefined
})
];
}, [order, id, user]);

View File

@ -448,7 +448,13 @@ export default function SalesOrderDetail() {
NotesPanel({
model_type: ModelType.salesorder,
model_id: order.pk,
has_note: !!order.notes
has_note: !!order.notes,
// TODO @matmair - change API to include a "locked" attribute that we can check here
editable:
order.status == soStatus.COMPLETE &&
!globalSettings.isSet('SALESORDER_EDIT_COMPLETED_ORDERS')
? false
: undefined
})
];
}, [order, id, user, soStatus, user]);